Skip to content

[Release Tooling] Re-order pod manifest #9783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

[Release Tooling] Re-order pod manifest #9783

merged 1 commit into from
May 9, 2022

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 9, 2022 •
edited
Loading

Context

  • FirebaseCore pods were being pushed in incorrect order.
  • FirebaseCoreExtension depends on FirebaseCore, which depends on FirebaseCoreInternal so they so should be pushed in reverse order
  • The interop pods don't depend on FirebaseCore* pods and I have them being pushed after FirebaseCore* pods. I think this should a buffer for the FirebaseCore* to be fully published by the time the product pods start being pushed

#no-changelog

@ncooke3 ncooke3 force-pushed the nc/release-tooling-push-ordering branch from dbdf4dc to 1713e69 Compare May 9, 2022 14:01
@ncooke3 ncooke3 requested a review from paulb777 May 9, 2022 14:01
paulb777
paulb777 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit a12e1a0 into master May 9, 2022
@ncooke3 ncooke3 deleted the nc/release-tooling-push-ordering branch May 9, 2022 14:10
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot