Skip to content

[v9.1.0] Update versions for Release 9.1.0 #9787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2022
Merged

[v9.1.0] Update versions for Release 9.1.0 #9787

merged 3 commits into from
May 10, 2022

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 9, 2022

#no-changelog

ncooke3
ncooke3 commented May 9, 2022
View reviewed changes
@ncooke3 ncooke3 requested a review from paulb777 May 9, 2022 22:14
@google-oss-bot
Copy link

google-oss-bot commented May 10, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 57.18% (e8da4e8) to 57.03% (2405994) by -0.15%.

    FilenameBase (e8da4e8)Merge (2405994)Diff
    FSRWebSocket.m40.45%38.43%-2.02%

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.14% (e8da4e8) to 88.14% (2405994) by +0.00%.

    FilenameBase (e8da4e8)Merge (2405994)Diff
    leveldb_key.cc98.09%98.59%+0.50%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bdwipPSaKQ.html

paulb777
paulb777 approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the one change noted.

The messaging failure looks like the recurring flake we've been seeing.

The zip release build will fail until the podspecs are pushed to SpecsStaging

@ncooke3
Copy link
Member Author

ncooke3 commented May 10, 2022

Merging because previous CI was green (apart from noted failures 👆) and latest commit should be low risk.

@ncooke3 ncooke3 merged commit 5182a31 into master May 10, 2022
@ncooke3 ncooke3 deleted the version-9.1 branch May 10, 2022 01:03
@ncooke3
Copy link
Member Author

ncooke3 commented May 10, 2022

All specs have been staged on https://github.com/firebase/SpecsStaging

@ncooke3 ncooke3 mentioned this pull request May 22, 2022
Merged
@ncooke3 ncooke3 mentioned this pull request Jun 3, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: analytics api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777