Merge branch 'master' into fei-rc-exp

Author: Feiyang1

.changeset/bright-ducks-jump.md

@@ -0,0 +1,7 @@
+---
+'firebase': minor
+'@firebase/database': minor
+'@firebase/database-types': minor
+---
+
+Add a useEmulator(host, port) method to Realtime Database

.changeset/silver-dolls-wave.md

@@ -0,0 +1,6 @@
+---
+"firebase": major
+"@firebase/firestore": major
+---
+
+This releases removes all input validation. Please use our TypeScript types to validate API usage. 

.changeset/tame-knives-change.md

@@ -0,0 +1,7 @@
+---
+"@firebase/database-types": patch
+"@firebase/database": patch
+"firebase": patch
+---
+
+Updated the type definition for `ThenableReference` to only implement `then` and `catch`, which matches the implementation.

.changeset/tiny-hounds-rest.md

@@ -0,0 +1,6 @@
+---
+"firebase: major
+"@firebase/storage": major
+---
+
+This releases removes all input validation. Please use our TypeScript types to validate API usage. 

.changeset/wicked-cups-search.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': minor
+---
+
+Removed excess validation of null and NaN values in query filters. This more closely aligns the SDK with the Firestore backend, which has always accepted null and NaN for all operators, even though this isn't necessarily useful.

common/api-review/auth-exp.api.md

@@ -123,6 +123,7 @@ export class EmailAuthProvider implements externs.EmailAuthProvider {
 
 // @public (undocumented)
 export class FacebookAuthProvider extends OAuthProvider {
+    constructor();
     // (undocumented)
     static credential(accessToken: string): externs.OAuthCredential;
     // (undocumented)
@@ -133,8 +134,6 @@ export class FacebookAuthProvider extends OAuthProvider {
     static readonly FACEBOOK_SIGN_IN_METHOD = externs.SignInMethod.FACEBOOK;
     // (undocumented)
     static readonly PROVIDER_ID = externs.ProviderId.FACEBOOK;
-    // (undocumented)
-    readonly providerId = externs.ProviderId.FACEBOOK;
 }
 
 // @public (undocumented)
@@ -160,6 +159,7 @@ export function getRedirectResult(authExtern: externs.Auth, resolverExtern?: ext
 
 // @public (undocumented)
 export class GithubAuthProvider extends OAuthProvider {
+    constructor();
     // (undocumented)
     static credential(accessToken: string): externs.OAuthCredential;
     // (undocumented)
@@ -170,12 +170,11 @@ export class GithubAuthProvider extends OAuthProvider {
     static readonly GITHUB_SIGN_IN_METHOD = externs.SignInMethod.GITHUB;
     // (undocumented)
     static readonly PROVIDER_ID = externs.ProviderId.GITHUB;
-    // (undocumented)
-    readonly providerId = externs.ProviderId.GITHUB;
 }
 
 // @public (undocumented)
 export class GoogleAuthProvider extends OAuthProvider {
+    constructor();
     // (undocumented)
     static credential(idToken?: string | null, accessToken?: string | null): externs.OAuthCredential;
     // (undocumented)
@@ -186,8 +185,6 @@ export class GoogleAuthProvider extends OAuthProvider {
     static readonly GOOGLE_SIGN_IN_METHOD = externs.SignInMethod.GOOGLE;
     // (undocumented)
     static readonly PROVIDER_ID = externs.ProviderId.GOOGLE;
-    // (undocumented)
-    readonly providerId = externs.ProviderId.GOOGLE;
 }
 
 // @public (undocumented)
@@ -404,6 +401,7 @@ export function signOut(auth: externs.Auth): Promise<void>;
 
 // @public (undocumented)
 export class TwitterAuthProvider extends OAuthProvider {
+    constructor();
     // (undocumented)
     static credential(token: string, secret: string): externs.OAuthCredential;
     // (undocumented)
@@ -413,8 +411,6 @@ export class TwitterAuthProvider extends OAuthProvider {
     // (undocumented)
     static readonly PROVIDER_ID = externs.ProviderId.TWITTER;
     // (undocumented)
-    readonly providerId = externs.ProviderId.TWITTER;
-    // (undocumented)
     static readonly TWITTER_SIGN_IN_METHOD = externs.SignInMethod.TWITTER;
 }
 

docs-exp/auth.facebookauthprovider._constructor_.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [@firebase/auth](./auth.md) &gt; [FacebookAuthProvider](./auth.facebookauthprovider.md) &gt; [(constructor)](./auth.facebookauthprovider._constructor_.md)
+
+## FacebookAuthProvider.(constructor)
+
+Constructs a new instance of the `FacebookAuthProvider` class
+
+<b>Signature:</b>
+
+```typescript
+constructor();
+```

docs-exp/auth.facebookauthprovider.md

@@ -11,13 +11,18 @@ export declare class FacebookAuthProvider extends OAuthProvider
 ```
 <b>Extends:</b> [OAuthProvider](./auth.oauthprovider.md)
 
+## Constructors
+
+|  Constructor | Modifiers | Description |
+|  --- | --- | --- |
+|  [(constructor)()](./auth.facebookauthprovider._constructor_.md) |  | Constructs a new instance of the <code>FacebookAuthProvider</code> class |
+
 ## Properties
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
 |  [FACEBOOK\_SIGN\_IN\_METHOD](./auth.facebookauthprovider.facebook_sign_in_method.md) | <code>static</code> | (not declared) |  |
 |  [PROVIDER\_ID](./auth.facebookauthprovider.provider_id.md) | <code>static</code> | (not declared) |  |
-|  [providerId](./auth.facebookauthprovider.providerid.md) |  | (not declared) |  |
 
 ## Methods
 

docs-exp/auth.githubauthprovider._constructor_.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [@firebase/auth](./auth.md) &gt; [GithubAuthProvider](./auth.githubauthprovider.md) &gt; [(constructor)](./auth.githubauthprovider._constructor_.md)
+
+## GithubAuthProvider.(constructor)
+
+Constructs a new instance of the `GithubAuthProvider` class
+
+<b>Signature:</b>
+
+```typescript
+constructor();
+```

docs-exp/auth.githubauthprovider.md

@@ -11,13 +11,18 @@ export declare class GithubAuthProvider extends OAuthProvider
 ```
 <b>Extends:</b> [OAuthProvider](./auth.oauthprovider.md)
 
+## Constructors
+
+|  Constructor | Modifiers | Description |
+|  --- | --- | --- |
+|  [(constructor)()](./auth.githubauthprovider._constructor_.md) |  | Constructs a new instance of the <code>GithubAuthProvider</code> class |
+
 ## Properties
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
 |  [GITHUB\_SIGN\_IN\_METHOD](./auth.githubauthprovider.github_sign_in_method.md) | <code>static</code> | (not declared) |  |
 |  [PROVIDER\_ID](./auth.githubauthprovider.provider_id.md) | <code>static</code> | (not declared) |  |
-|  [providerId](./auth.githubauthprovider.providerid.md) |  | (not declared) |  |
 
 ## Methods
 

docs-exp/auth.googleauthprovider._constructor_.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [@firebase/auth](./auth.md) &gt; [GoogleAuthProvider](./auth.googleauthprovider.md) &gt; [(constructor)](./auth.googleauthprovider._constructor_.md)
+
+## GoogleAuthProvider.(constructor)
+
+Constructs a new instance of the `GoogleAuthProvider` class
+
+<b>Signature:</b>
+
+```typescript
+constructor();
+```

docs-exp/auth.googleauthprovider.md

@@ -11,13 +11,18 @@ export declare class GoogleAuthProvider extends OAuthProvider
 ```
 <b>Extends:</b> [OAuthProvider](./auth.oauthprovider.md)
 
+## Constructors
+
+|  Constructor | Modifiers | Description |
+|  --- | --- | --- |
+|  [(constructor)()](./auth.googleauthprovider._constructor_.md) |  | Constructs a new instance of the <code>GoogleAuthProvider</code> class |
+
 ## Properties
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
 |  [GOOGLE\_SIGN\_IN\_METHOD](./auth.googleauthprovider.google_sign_in_method.md) | <code>static</code> | (not declared) |  |
 |  [PROVIDER\_ID](./auth.googleauthprovider.provider_id.md) | <code>static</code> | (not declared) |  |
-|  [providerId](./auth.googleauthprovider.providerid.md) |  | (not declared) |  |
 
 ## Methods
 

docs-exp/auth.twitterauthprovider._constructor_.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [@firebase/auth](./auth.md) &gt; [TwitterAuthProvider](./auth.twitterauthprovider.md) &gt; [(constructor)](./auth.twitterauthprovider._constructor_.md)
+
+## TwitterAuthProvider.(constructor)
+
+Constructs a new instance of the `TwitterAuthProvider` class
+
+<b>Signature:</b>
+
+```typescript
+constructor();
+```

docs-exp/auth.twitterauthprovider.md

@@ -11,12 +11,17 @@ export declare class TwitterAuthProvider extends OAuthProvider
 ```
 <b>Extends:</b> [OAuthProvider](./auth.oauthprovider.md)
 
+## Constructors
+
+|  Constructor | Modifiers | Description |
+|  --- | --- | --- |
+|  [(constructor)()](./auth.twitterauthprovider._constructor_.md) |  | Constructs a new instance of the <code>TwitterAuthProvider</code> class |
+
 ## Properties
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
 |  [PROVIDER\_ID](./auth.twitterauthprovider.provider_id.md) | <code>static</code> | (not declared) |  |
-|  [providerId](./auth.twitterauthprovider.providerid.md) |  | (not declared) |  |
 |  [TWITTER\_SIGN\_IN\_METHOD](./auth.twitterauthprovider.twitter_sign_in_method.md) | <code>static</code> | (not declared) |  |
 
 ## Methods

packages-exp/auth-compat-exp/src/auth.test.ts

@@ -48,7 +48,7 @@ describe('auth compat', () => {
       if (typeof self !== 'undefined') {
         sinon.stub(underlyingAuth, '_getPersistence').returns('TEST');
         // eslint-disable-next-line @typescript-eslint/no-floating-promises
-        authCompat.signInWithRedirect(new impl.GoogleAuthProvider('google'));
+        authCompat.signInWithRedirect(new impl.GoogleAuthProvider());
         expect(
           sessionStorage.getItem('firebase:persistence:api-key:undefined')
         ).to.eq('TEST');

packages-exp/auth-exp/src/core/providers/facebook.ts

@@ -26,7 +26,10 @@ import { OAuthProvider } from './oauth';
 export class FacebookAuthProvider extends OAuthProvider {
   static readonly FACEBOOK_SIGN_IN_METHOD = externs.SignInMethod.FACEBOOK;
   static readonly PROVIDER_ID = externs.ProviderId.FACEBOOK;
-  readonly providerId = FacebookAuthProvider.PROVIDER_ID;
+
+  constructor() {
+    super(externs.ProviderId.FACEBOOK);
+  }
 
   static credential(accessToken: string): externs.OAuthCredential {
     return OAuthCredential._fromParams({

packages-exp/auth-exp/src/core/providers/github.ts

@@ -26,7 +26,10 @@ import { OAuthProvider } from './oauth';
 export class GithubAuthProvider extends OAuthProvider {
   static readonly GITHUB_SIGN_IN_METHOD = externs.SignInMethod.GITHUB;
   static readonly PROVIDER_ID = externs.ProviderId.GITHUB;
-  readonly providerId = GithubAuthProvider.PROVIDER_ID;
+
+  constructor() {
+    super(externs.ProviderId.GITHUB);
+  }
 
   static credential(accessToken: string): externs.OAuthCredential {
     return OAuthCredential._fromParams({

packages-exp/auth-exp/src/core/providers/google.ts

@@ -27,7 +27,10 @@ import { OAuthProvider } from './oauth';
 export class GoogleAuthProvider extends OAuthProvider {
   static readonly GOOGLE_SIGN_IN_METHOD = externs.SignInMethod.GOOGLE;
   static readonly PROVIDER_ID = externs.ProviderId.GOOGLE;
-  readonly providerId = GoogleAuthProvider.PROVIDER_ID;
+
+  constructor() {
+    super(externs.ProviderId.GOOGLE);
+  }
 
   static credential(
     idToken?: string | null,

packages-exp/auth-exp/src/core/providers/twitter.ts

@@ -44,7 +44,10 @@ import { OAuthProvider } from './oauth';
 export class TwitterAuthProvider extends OAuthProvider {
   static readonly TWITTER_SIGN_IN_METHOD = externs.SignInMethod.TWITTER;
   static readonly PROVIDER_ID = externs.ProviderId.TWITTER;
-  readonly providerId = TwitterAuthProvider.PROVIDER_ID;
+
+  constructor() {
+    super(externs.ProviderId.TWITTER);
+  }
 
   static credential(token: string, secret: string): externs.OAuthCredential {
     return OAuthCredential._fromParams({

packages/database-types/index.d.ts

@@ -34,6 +34,7 @@ export interface DataSnapshot {
 
 export interface Database {
   app: FirebaseApp;
+  useEmulator(host: string, port: number): void;
   goOffline(): void;
   goOnline(): void;
   ref(path?: string | Reference): Reference;
@@ -43,6 +44,7 @@ export interface Database {
 export class FirebaseDatabase implements Database {
   private constructor();
   app: FirebaseApp;
+  useEmulator(host: string, port: number): void;
   goOffline(): void;
   goOnline(): void;
   ref(path?: string | Reference): Reference;
@@ -106,7 +108,7 @@ export interface Reference extends Query {
   key: string | null;
   onDisconnect(): OnDisconnect;
   parent: Reference | null;
-  push(value?: any, onComplete?: (a: Error | null) => any): Reference;
+  push(value?: any, onComplete?: (a: Error | null) => any): ThenableReference;
   remove(onComplete?: (a: Error | null) => any): Promise<any>;
   root: Reference;
   set(value: any, onComplete?: (a: Error | null) => any): Promise<any>;
@@ -132,7 +134,9 @@ export interface ServerValue {
   increment(delta: number): Object;
 }
 
-export interface ThenableReference extends Reference, Promise<Reference> {}
+export interface ThenableReference
+  extends Reference,
+    Pick<Promise<Reference>, 'then' | 'catch'> {}
 
 export function enableLogging(
   logger?: boolean | ((a: string) => any),