Skip to content

Commit 2e388bc

Browse files
committed
fix spec tests in listen_spec.test.ts and recovery_spec.test.ts
1 parent d18be98 commit 2e388bc

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -350,19 +350,20 @@ describeSpec('Listens:', [], () => {
350350
// us up to docAV2 since that's the last relevant change to the query
351351
// (the document falls out) and send us a snapshot that's ahead of
352352
// docAv3 (which is already in our cache).
353-
.userListens(visibleQuery, { resumeToken: 'resume-token-4000' })
354-
// .watchAcks(visibleQuery)
355-
// .watchSends({ removed: [visibleQuery] }, docAv2)
356-
// .watchCurrents(visibleQuery, 'resume-token-5000')
357-
// .watchSnapshots(5000)
358-
// .expectEvents(visibleQuery, { fromCache: false })
359-
// .userUnlistens(visibleQuery)
360-
// .watchRemoves(visibleQuery)
361-
// // Listen to allQuery again and make sure we still get docAv3.
362-
// .userListens(allQuery, { resumeToken: 'resume-token-4000' })
363-
// .expectEvents(allQuery, { added: [docAv3], fromCache: true })
364-
// .watchAcksFull(allQuery, 6000)
365-
// .expectEvents(allQuery, { fromCache: false })
353+
.userListens(visibleQuery, { resumeToken: 'resume-token-1000' })
354+
.expectEvents(visibleQuery, { fromCache: true })
355+
.watchAcks(visibleQuery)
356+
.watchSends({ removed: [visibleQuery] }, docAv2)
357+
.watchCurrents(visibleQuery, 'resume-token-5000')
358+
.watchSnapshots(5000)
359+
.expectEvents(visibleQuery, { fromCache: false })
360+
.userUnlistens(visibleQuery)
361+
.watchRemoves(visibleQuery)
362+
// Listen to allQuery again and make sure we still get docAv3.
363+
.userListens(allQuery, { resumeToken: 'resume-token-4000' })
364+
.expectEvents(allQuery, { added: [docAv3], fromCache: true })
365+
.watchAcksFull(allQuery, 6000)
366+
.expectEvents(allQuery, { fromCache: false })
366367
);
367368
});
368369

@@ -396,6 +397,7 @@ describeSpec('Listens:', [], () => {
396397
// (the document falls out) and send us a snapshot that's ahead of
397398
// docAv3 (which is already in our cache).
398399
.userListens(visibleQuery, { resumeToken: 'resume-token-1000' })
400+
.expectEvents(visibleQuery, { fromCache: true })
399401
.watchAcks(visibleQuery)
400402
.watchSends({ removed: [visibleQuery] }, docAv2)
401403
.watchCurrents(visibleQuery, 'resume-token-5000')
@@ -405,6 +407,7 @@ describeSpec('Listens:', [], () => {
405407
.watchRemoves(visibleQuery)
406408
// Listen to allQuery again and make sure we still get no docs.
407409
.userListens(allQuery, { resumeToken: 'resume-token-4000' })
410+
.expectEvents(allQuery, { fromCache: true })
408411
.watchAcksFull(allQuery, 6000)
409412
.expectEvents(allQuery, { fromCache: false })
410413
);

packages/firestore/test/unit/specs/recovery_spec.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,7 @@ describeSpec('Persistence Recovery', ['no-ios', 'no-android'], () => {
489489
.userUnlistens(query1)
490490
// No event since the document was removed
491491
.userListens(query1, { resumeToken: 'resume-token-1000' })
492+
.expectEvents(query1, { fromCache: true })
492493
);
493494
}
494495
);

0 commit comments

Comments
 (0)