Whee! Auto-remove unused imports (#4107)

Author: schmidt-sebastian

config/.eslintrc.js

@@ -24,7 +24,12 @@ module.exports = {
     'node': true
   },
   'parser': '@typescript-eslint/parser',
-  'plugins': ['@typescript-eslint', '@typescript-eslint/tslint', 'import'],
+  'plugins': [
+    '@typescript-eslint',
+    '@typescript-eslint/tslint',
+    'import',
+    'unused-imports'
+  ],
   'parserOptions': {
     'ecmaVersion': 2015,
     'sourceType': 'module'
@@ -72,6 +77,7 @@ module.exports = {
       }
     ],
     'radix': 'error',
+    'unused-imports/no-unused-imports-ts': 'error',
     'default-case': 'error',
     'eqeqeq': [
       'error',

package.json

@@ -47,6 +47,7 @@
     "docgen": "yarn docgen:js; yarn docgen:node",
     "prettier": "prettier --config .prettierrc --write '**/*.{ts,js}'",
     "lint": "lerna run --scope @firebase/* --scope rxfire lint",
+    "lint:fix": "lerna run --scope @firebase/* --scope rxfire lint:fix",
     "size-report": "ts-node-script scripts/size_report/report_binary_size.ts",
     "modular-export-size-report": "ts-node-script scripts/size_report/report_modular_export_binary_size.ts",
     "api-report": "lerna run --scope @firebase/*-exp --scope @firebase/firestore api-report",
@@ -65,10 +66,11 @@
     "repo-scripts/*"
   ],
   "devDependencies": {
+    "@babel/core": "7.12.3",
+    "@babel/plugin-transform-modules-commonjs": "7.12.1",
+    "@babel/preset-env": "7.12.1",
     "@changesets/changelog-github": "0.2.7",
     "@changesets/cli": "2.11.2",
-    "api-documenter-me": "0.1.0",
-    "api-extractor-me": "0.1.0",
     "@types/chai": "4.2.14",
     "@types/chai-as-promised": "7.1.3",
     "@types/child-process-promise": "2.2.1",
@@ -86,10 +88,9 @@
     "@typescript-eslint/eslint-plugin": "4.8.1",
     "@typescript-eslint/eslint-plugin-tslint": "4.8.1",
     "@typescript-eslint/parser": "4.8.1",
+    "api-documenter-me": "0.1.0",
+    "api-extractor-me": "0.1.0",
     "babel-loader": "8.2.1",
-    "@babel/core": "7.12.3",
-    "@babel/preset-env": "7.12.1",
-    "@babel/plugin-transform-modules-commonjs": "7.12.1",
     "chai": "4.2.0",
     "chai-as-promised": "7.1.1",
     "chalk": "4.1.0",
@@ -100,6 +101,7 @@
     "dependency-graph": "0.9.0",
     "eslint": "7.13.0",
     "eslint-plugin-import": "2.22.1",
+    "eslint-plugin-unused-imports": "1.0.0",
     "express": "4.17.1",
     "find-free-port": "2.0.0",
     "firebase-functions": "3.11.0",

packages-exp/app-compat/src/firebaseApp.ts

@@ -17,7 +17,6 @@
 
 import { FirebaseApp, FirebaseOptions } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseService
 } from '@firebase/app-types/private';

packages-exp/app-compat/src/firebaseNamespace.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseNamespace } from '@firebase/app-types';
-import { _FirebaseApp, _FirebaseNamespace } from '@firebase/app-types/private';
+import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { createSubscribe, deepExtend, ErrorFactory } from '@firebase/util';
 import { FirebaseAppImpl } from './firebaseApp';
 import { createFirebaseNamespaceCore } from './firebaseNamespaceCore';

packages-exp/app-compat/src/firebaseNamespaceCore.ts

@@ -21,7 +21,6 @@ import {
   FirebaseNamespace
 } from '@firebase/app-types'; // TODO: create @firebase/app-types-compat before the official release
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseService,
   FirebaseServiceNamespace

packages-exp/app-compat/src/lite/firebaseAppLite.ts

@@ -17,7 +17,6 @@
 
 import { FirebaseApp, FirebaseOptions } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseService
 } from '@firebase/app-types/private';

packages-exp/app-compat/src/lite/firebaseNamespaceLite.ts

@@ -17,7 +17,6 @@
 
 import { FirebaseNamespace } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseServiceNamespace,
   FirebaseService

packages-exp/app-compat/src/registerCoreComponents.ts

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 
-import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { registerVersion } from '@firebase/app-exp';
 
 import { name, version } from '../package.json';

packages-exp/app-exp/src/platformLoggerService.test.ts

@@ -16,7 +16,6 @@
  */
 
 import { VersionService } from '@firebase/app-types';
-import { _FirebaseApp, _FirebaseNamespace } from '@firebase/app-types/private';
 import { expect } from 'chai';
 import '../test/setup';
 import { PlatformLoggerService } from './platformLoggerService';

packages-exp/auth-compat-exp/src/auth.ts

@@ -28,7 +28,7 @@ import {
 } from '@firebase/util';
 
 import { _validatePersistenceArgument, Persistence } from './persistence';
-import { _getClientPlatform, _isPopupRedirectSupported } from './platform';
+import { _isPopupRedirectSupported } from './platform';
 import { User } from './user';
 import {
   convertConfirmationResult,

packages-exp/auth-exp/src/core/auth/initialize.ts

@@ -22,7 +22,7 @@ import * as externs from '@firebase/auth-types-exp';
 import { Dependencies } from '../../model/auth';
 import { Persistence } from '../persistence';
 import { _getInstance } from '../util/instantiator';
-import { _castAuth, AuthImpl } from './auth_impl';
+import { AuthImpl } from './auth_impl';
 
 /** @public */
 export function initializeAuth(

packages-exp/auth-exp/src/core/errors.test.ts

@@ -23,7 +23,6 @@ import {
   ErrorMapRetriever,
   AuthErrorParams
 } from './errors';
-import { _createError } from './util/assert';
 import { AuthErrorMap } from '@firebase/auth-types-exp';
 import { ErrorFactory } from '@firebase/util';
 

packages-exp/auth-exp/src/core/strategies/email.ts

@@ -25,7 +25,6 @@ import * as api from '../../api/authentication/email_and_password';
 import { User } from '../../model/user';
 import { _getCurrentUrl, _isHttpOrHttps } from '../util/location';
 import { _setActionCodeSettingsOnRequest } from './action_code_settings';
-import { _castAuth } from '../auth/auth_impl';
 
 /**
  * Gets the list of possible sign in methods for the given email address.

packages-exp/auth-exp/src/core/user/account_info.ts

@@ -24,7 +24,6 @@ import {
 import { updateProfile as apiUpdateProfile } from '../../api/account_management/profile';
 import { User } from '../../model/user';
 import { _logoutIfInvalidated } from './invalidation';
-import { _reloadWithoutSaving } from './reload';
 
 interface Profile {
   displayName?: string | null;

packages-exp/auth-exp/src/core/user/link_unlink.ts

@@ -18,7 +18,6 @@
 import * as externs from '@firebase/auth-types-exp';
 
 import { deleteLinkedAccounts } from '../../api/account_management/account';
-import { _processCredentialSavingMfaContextIfNecessary } from '../../mfa/mfa_error';
 import { User, UserCredential } from '../../model/user';
 import { AuthCredential } from '../credentials';
 import { AuthErrorCode } from '../errors';

packages-exp/auth-exp/src/platform_browser/auth.test.ts

@@ -24,7 +24,7 @@ import { FirebaseApp } from '@firebase/app-types-exp';
 import * as externs from '@firebase/auth-types-exp';
 
 import { testAuth, testUser } from '../../test/helpers/mock_auth';
-import { _castAuth, AuthImpl, DefaultConfig } from '../core/auth/auth_impl';
+import { AuthImpl, DefaultConfig } from '../core/auth/auth_impl';
 import { _initializeAuthInstance } from '../core/auth/initialize';
 import { AuthErrorCode } from '../core/errors';
 import { Persistence } from '../core/persistence';

packages-exp/auth-exp/src/platform_browser/recaptcha/recaptcha_verifier.test.ts

@@ -28,7 +28,7 @@ import * as fetch from '../../../test/helpers/mock_fetch';
 import { Endpoint } from '../../api';
 import { _window } from '../auth_window';
 import { Parameters, Recaptcha } from './recaptcha';
-import { _JSLOAD_CALLBACK, ReCaptchaLoader } from './recaptcha_loader';
+import { ReCaptchaLoader } from './recaptcha_loader';
 import { MockReCaptcha } from './recaptcha_mock';
 import { RecaptchaVerifier } from './recaptcha_verifier';
 

packages-exp/auth-exp/src/platform_browser/strategies/popup.ts

@@ -23,7 +23,6 @@ import { OAuthProvider } from '../../core/providers/oauth';
 import { _assert, debugAssert, _createError } from '../../core/util/assert';
 import { Delay } from '../../core/util/delay';
 import { _generateEventId } from '../../core/util/event_id';
-import { _getInstance } from '../../core/util/instantiator';
 import { Auth } from '../../model/auth';
 import {
   AuthEventType,

packages-exp/auth-exp/src/platform_browser/strategies/redirect.ts

@@ -23,7 +23,6 @@ import { AuthErrorCode } from '../../core/errors';
 import { _assertLinkedStatus } from '../../core/user/link_unlink';
 import { _assert } from '../../core/util/assert';
 import { _generateEventId } from '../../core/util/event_id';
-import { _getInstance } from '../../core/util/instantiator';
 import { Auth } from '../../model/auth';
 import {
   AuthEvent,

packages-exp/installations-exp/src/functions/config.ts

@@ -16,7 +16,6 @@
  */
 
 import { _registerComponent, _getProvider } from '@firebase/app-exp';
-import { _FirebaseService } from '@firebase/app-types-exp';
 import {
   Component,
   ComponentType,

packages-exp/performance-exp/package.json

@@ -11,7 +11,7 @@
   "files": ["dist"],
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
-    "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts'",
+    "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "build": "rollup -c && yarn api-report",
     "build:deps": "lerna run --scope @firebase/performance-exp --include-dependencies build",
     "build:release": "rollup -c rollup.config.release.js",

packages/app/src/firebaseApp.ts

@@ -21,7 +21,6 @@ import {
   FirebaseAppConfig
 } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseService
 } from '@firebase/app-types/private';

packages/app/src/firebaseNamespace.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseNamespace } from '@firebase/app-types';
-import { _FirebaseApp, _FirebaseNamespace } from '@firebase/app-types/private';
+import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { createSubscribe, deepExtend, ErrorFactory } from '@firebase/util';
 import { FirebaseAppImpl } from './firebaseApp';
 import { createFirebaseNamespaceCore } from './firebaseNamespaceCore';

packages/app/src/lite/firebaseAppLite.ts

@@ -21,7 +21,6 @@ import {
   FirebaseAppConfig
 } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseService
 } from '@firebase/app-types/private';

packages/app/src/lite/firebaseNamespaceLite.ts

@@ -17,7 +17,6 @@
 
 import { FirebaseNamespace } from '@firebase/app-types';
 import {
-  _FirebaseApp,
   _FirebaseNamespace,
   FirebaseServiceNamespace,
   FirebaseService

packages/app/test/clientLogger.test.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseNamespace, VersionService } from '@firebase/app-types';
-import { _FirebaseApp, _FirebaseNamespace } from '@firebase/app-types/private';
+import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { createFirebaseNamespace } from '../src/firebaseNamespace';
 import { expect } from 'chai';
 import { spy as Spy } from 'sinon';

packages/app/test/platformLogger.test.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseNamespace, VersionService } from '@firebase/app-types';
-import { _FirebaseApp, _FirebaseNamespace } from '@firebase/app-types/private';
+import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { createFirebaseNamespace } from '../src/firebaseNamespace';
 import { expect } from 'chai';
 import './setup';

packages/database/index.node.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseNamespace, FirebaseApp } from '@firebase/app-types';
-import { _FirebaseNamespace, _FirebaseApp } from '@firebase/app-types/private';
+import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { Database } from './src/api/Database';
 import { DataSnapshot } from './src/api/DataSnapshot';
 import { Query } from './src/api/Query';

packages/database/src/api/Database.ts

@@ -25,8 +25,6 @@ import { validateArgCount } from '@firebase/util';
 import { validateUrl } from '../core/util/validation';
 import { FirebaseApp } from '@firebase/app-types';
 import { FirebaseService } from '@firebase/app-types/private';
-import { RepoInfo } from '../core/RepoInfo';
-import { FirebaseDatabase } from '@firebase/database-types';
 
 /**
  * Class representing a firebase database.

packages/database/src/api/Reference.ts

@@ -37,7 +37,6 @@ import { validateArgCount, validateCallback, Deferred } from '@firebase/util';
 import { SyncPoint } from '../core/SyncPoint';
 import { Database } from './Database';
 import { DataSnapshot } from './DataSnapshot';
-import * as types from '@firebase/database-types';
 
 export interface ReferenceConstructor {
   new (repo: Repo, path: Path): Reference;

packages/database/src/core/PersistentConnection.ts

@@ -19,7 +19,6 @@ import {
   contains,
   isEmpty,
   safeGet,
-  CONSTANTS,
   stringify,
   assert,
   isAdmin,

packages/database/src/core/Repo.ts

@@ -45,8 +45,6 @@ import { EventRegistration } from './view/EventRegistration';
 import { StatsCollection } from './stats/StatsCollection';
 import { Event } from './view/Event';
 import { Node } from './snap/Node';
-import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
-import { Provider } from '@firebase/component';
 import { Indexable } from './util/misc';
 
 const INTERRUPT_REASON = 'repo_interrupt';

packages/database/src/core/RepoManager.ts

@@ -16,7 +16,7 @@
  */
 
 import { FirebaseApp } from '@firebase/app-types';
-import { safeGet, CONSTANTS } from '@firebase/util';
+import { safeGet } from '@firebase/util';
 import { Repo } from './Repo';
 import { fatal, log } from './util/util';
 import { parseRepoInfo } from './util/libs/parser';

packages/database/src/core/SyncPoint.ts

@@ -27,7 +27,7 @@ import { EventRegistration } from './view/EventRegistration';
 import { Node } from './snap/Node';
 import { Path } from './util/Path';
 import { Event } from './view/Event';
-import { Reference, ReferenceConstructor } from '../api/Reference';
+import { ReferenceConstructor } from '../api/Reference';
 
 let __referenceConstructor: ReferenceConstructor;
 

packages/database/src/core/snap/indexes/Index.ts

@@ -16,7 +16,7 @@
  */
 
 import { Node, NamedNode } from '../Node';
-import { MIN_NAME, MAX_NAME } from '../../util/util';
+import { MIN_NAME } from '../../util/util';
 import { Comparator } from '../../util/SortedMap';
 
 /**

packages/database/src/core/util/ServerValues.ts

@@ -17,7 +17,6 @@
 
 import { assert } from '@firebase/util';
 import { Path } from './Path';
-import { SparseSnapshotTree } from '../SparseSnapshotTree';
 import { LeafNode } from '../snap/LeafNode';
 import { nodeFromJSON } from '../snap/nodeFromJSON';
 import { PRIORITY_INDEX } from '../snap/indexes/PriorityIndex';

packages/database/src/realtime/WebSocketConnection.ts

@@ -18,7 +18,6 @@
 import { RepoInfo } from '../core/RepoInfo';
 import {
   assert,
-  CONSTANTS as ENV_CONSTANTS,
   jsonEval,
   stringify,
   isNodeSdk

packages/database/test/servervalues.test.ts

@@ -16,10 +16,9 @@
  */
 
 import { expect } from 'chai';
-import { getFreshRepoFromReference, getRandomNode } from './helpers/util';
+import { getRandomNode } from './helpers/util';
 import { Database } from '../src/api/Database';
 import { Reference } from '../src/api/Reference';
-import { nodeFromJSON } from '../src/core/snap/nodeFromJSON';
 
 describe('ServerValue tests', () => {
   it('resolves timestamps locally', async () => {

packages/firestore/.eslintrc.js

@@ -26,7 +26,6 @@ module.exports = {
   plugins: ['import'],
   rules: {
     'no-console': ['error', { allow: ['warn', 'error'] }],
-    'import/no-default-export': 'error',
     '@typescript-eslint/no-unused-vars': [
       'error',
       {

packages/firestore/package.json

@@ -74,13 +74,13 @@
   "devDependencies": {
     "@firebase/app": "0.6.13",
     "@rollup/plugin-alias": "3.1.1",
+    "@rollup/plugin-json": "4.1.0",
+    "@rollup/plugin-node-resolve": "9.0.0",
     "@types/json-stable-stringify": "1.0.32",
     "json-stable-stringify": "1.0.1",
     "protobufjs": "6.10.2",
     "rollup": "2.33.2",
     "rollup-plugin-copy-assets": "1.1.0",
-    "@rollup/plugin-json": "4.1.0",
-    "@rollup/plugin-node-resolve": "9.0.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-terser": "7.0.2",