Skip to content

Whee! Auto-remove unused imports #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2020
Merged

Whee! Auto-remove unused imports #4107

merged 3 commits into from
Nov 23, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Nov 21, 2020 •
edited
Loading

This works with yarn lint:fix.

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: cea1ed2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 21, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (4ffb664) and head commit (5018428).

Test Logs

Feiyang1
Feiyang1 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind moving it to the shared eslint config?

@schmidt-sebastian
Copy link
Contributor Author

Moved to shared config

@schmidt-sebastian schmidt-sebastian merged commit 3045a0e into master Nov 23, 2020
@firebase firebase locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@alikn alikn Awaiting requested review from alikn

@avolkovi avolkovi Awaiting requested review from avolkovi

@jsdt jsdt Awaiting requested review from jsdt

@sam-gc sam-gc Awaiting requested review from sam-gc

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@Feiyang1 Feiyang1

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @Feiyang1