Skip to content

Commit 3e1495b

Browse files
committed
resolve comments
1 parent 91f720d commit 3e1495b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/firestore/src/core/view.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,9 @@ export class View {
321321
newSyncState === SyncState.Local,
322322
syncStateChanged,
323323
/* excludesMetadataChanges= */ false,
324-
targetChange !== undefined &&
325-
targetChange.resumeToken.approximateByteSize() > 0
324+
targetChange
325+
? targetChange.resumeToken.approximateByteSize() > 0
326+
: false
326327
);
327328
return {
328329
snapshot: snap,

packages/firestore/test/unit/api/database.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ describe('QuerySnapshot', () => {
177177
querySnapshot('foo', {}, { a: { a: 1 } }, keys('foo/a'), false, true)
178178
)
179179
).to.be.false;
180-
// hasCachedResults should effect querySnapshot equality
180+
// hasCachedResults should affect querySnapshot equality
181181
expect(
182182
snapshotEqual(
183183
querySnapshot(

0 commit comments

Comments
 (0)