Skip to content

Commit 3fc2c0b

Browse files
authored
Fix version name lookup for exp packages (#4440)
1 parent 949c6ac commit 3fc2c0b

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

packages-exp/app-exp/src/api.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ describe('API tests', () => {
215215
const warnStub = stub(console, 'warn');
216216
const initialSize = _components.size;
217217

218-
registerVersion('@firebase/analytics', '1.2.3');
218+
registerVersion('@firebase/analytics-exp', '1.2.3');
219219
expect(_components.get('fire-analytics-version')).to.exist;
220220
expect(_components.size).to.equal(initialSize + 1);
221221

packages-exp/app-exp/src/constants.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,18 @@
1717

1818
import { name as appName } from '../package.json';
1919
import { name as appCompatName } from '../../app-compat/package.json';
20-
import { name as analyticsName } from '../../../packages/analytics/package.json';
21-
import { name as authName } from '../../../packages/auth/package.json';
20+
import { name as analyticsName } from '../../../packages-exp/analytics-exp/package.json';
21+
import { name as authName } from '../../../packages-exp/auth-exp/package.json';
22+
import { name as authCompatName } from '../../../packages-exp/auth-compat-exp/package.json';
2223
import { name as databaseName } from '../../../packages/database/package.json';
2324
import { name as functionsName } from '../../../packages-exp/functions-exp/package.json';
2425
import { name as functionsCompatName } from '../../../packages-exp/functions-compat/package.json';
25-
import { name as installationsName } from '../../../packages/installations/package.json';
26-
import { name as messagingName } from '../../../packages/messaging/package.json';
27-
import { name as performanceName } from '../../../packages/performance/package.json';
28-
import { name as remoteConfigName } from '../../../packages/remote-config/package.json';
26+
import { name as installationsName } from '../../../packages-exp/installations-exp/package.json';
27+
import { name as installationsCompatName } from '../../../packages-exp/installations-compat/package.json';
28+
import { name as messagingName } from '../../../packages-exp/messaging-exp/package.json';
29+
import { name as performanceName } from '../../../packages-exp/performance-exp/package.json';
30+
import { name as remoteConfigName } from '../../../packages-exp/remote-config-exp/package.json';
31+
import { name as remoteConfigCompatName } from '../../../packages-exp/remote-config-compat/package.json';
2932
import { name as storageName } from '../../../packages/storage/package.json';
3033
import { name as firestoreName } from '../../../packages/firestore/package.json';
3134
import { name as packageName } from '../../../packages-exp/firebase-exp/package.json';
@@ -42,13 +45,16 @@ export const PLATFORM_LOG_STRING = {
4245
[appCompatName]: 'fire-core-compat',
4346
[analyticsName]: 'fire-analytics',
4447
[authName]: 'fire-auth',
48+
[authCompatName]: 'fire-auth-compat',
4549
[databaseName]: 'fire-rtdb',
4650
[functionsName]: 'fire-fn',
4751
[functionsCompatName]: 'fire-fn-compat',
4852
[installationsName]: 'fire-iid',
53+
[installationsCompatName]: 'fire-iid-compat',
4954
[messagingName]: 'fire-fcm',
5055
[performanceName]: 'fire-perf',
5156
[remoteConfigName]: 'fire-rc',
57+
[remoteConfigCompatName]: 'fire-rc-compat',
5258
[storageName]: 'fire-gcs',
5359
[firestoreName]: 'fire-fst',
5460
'fire-js': 'fire-js', // Platform identifier for JS SDK.

0 commit comments

Comments
 (0)