Syntax fixes in 'app' packages (#4409)

Author: hsubox76

common/api-review/app-exp.api.md

@@ -5,9 +5,9 @@
 ```ts
 
 import { Component } from '@firebase/component';
-import { FirebaseApp } from '@firebase/app-types';
-import { FirebaseAppConfig } from '@firebase/app-types';
-import { FirebaseOptions } from '@firebase/app-types';
+import { FirebaseApp } from '@firebase/app-types-exp';
+import { FirebaseAppConfig } from '@firebase/app-types-exp';
+import { FirebaseOptions } from '@firebase/app-types-exp';
 import { LogCallback } from '@firebase/logger';
 import { LogLevelString } from '@firebase/logger';
 import { LogOptions } from '@firebase/logger';

packages-exp/app-compat/src/firebaseApp.ts

@@ -68,7 +68,7 @@ export class FirebaseAppImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.app.checkDestroyed();
       resolve();
     }).then(() => {

packages-exp/app-exp/src/api.ts

@@ -284,9 +284,7 @@ export function onLog(
   options?: LogOptions
 ): void {
   if (logCallback !== null && typeof logCallback !== 'function') {
-    throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT, {
-      appName: name
-    });
+    throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT);
   }
   setUserLogHandler(logCallback, options);
 }

packages-exp/app-exp/src/errors.ts

@@ -40,7 +40,13 @@ const ERRORS: ErrorMap<AppError> = {
     'First argument to `onLog` must be null or a function.'
 };
 
-type ErrorParams = { [key in AppError]: { appName: string } };
+interface ErrorParams {
+  [AppError.NO_APP]: { appName: string };
+  [AppError.BAD_APP_NAME]: { appName: string };
+  [AppError.DUPLICATE_APP]: { appName: string };
+  [AppError.APP_DELETED]: { appName: string };
+  [AppError.INVALID_APP_ARGUMENT]: { appName: string };
+}
 
 export const ERROR_FACTORY = new ErrorFactory<AppError, ErrorParams>(
   'app',

packages/app/src/errors.ts

@@ -40,7 +40,13 @@ const ERRORS: ErrorMap<AppError> = {
     'First argument to `onLog` must be null or a function.'
 };
 
-type ErrorParams = { [key in AppError]: { appName: string } };
+interface ErrorParams {
+  [AppError.NO_APP]: { appName: string };
+  [AppError.BAD_APP_NAME]: { appName: string };
+  [AppError.DUPLICATE_APP]: { appName: string };
+  [AppError.APP_DELETED]: { appName: string };
+  [AppError.INVALID_APP_ARGUMENT]: { appName: string };
+}
 
 export const ERROR_FACTORY = new ErrorFactory<AppError, ErrorParams>(
   'app',

packages/app/src/firebaseApp.ts

@@ -86,7 +86,7 @@ export class FirebaseAppImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.checkDestroyed_();
       resolve();
     })

packages/app/src/firebaseNamespaceCore.ts

@@ -287,9 +287,7 @@ export function createFirebaseNamespaceCore(
 
   function onLog(logCallback: LogCallback | null, options?: LogOptions): void {
     if (logCallback !== null && typeof logCallback !== 'function') {
-      throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT, {
-        appName: name
-      });
+      throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT);
     }
     setUserLogHandler(logCallback, options);
   }

packages/app/src/lite/firebaseAppLite.ts

@@ -90,7 +90,7 @@ export class FirebaseAppLiteImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.checkDestroyed_();
       resolve();
     })

packages/app/src/lite/firebaseNamespaceLite.ts

@@ -48,7 +48,9 @@ export function createFirebaseNamespaceLite(): FirebaseNamespace {
       component.name !== 'performance' &&
       component.name !== 'installations'
     ) {
-      throw Error(`${name} cannot register with the standalone perf instance`);
+      throw Error(
+        `${component.name} cannot register with the standalone perf instance`
+      );
     }
 
     return registerComponent(component);