Syntax fixes in 'app' packages #4409

hsubox76 · 2021-02-03T19:39:28Z

Fix some things that will cause errors if upgrading to Typescript 4.1.+ (the upgrade isn't being done in this PR, other packages need to be fixed as well).

I think referencing name when it hadn't been passed in didn't show up as an error before because it's also a global variable?

changeset-bot · 2021-02-03T19:39:31Z

⚠️ No Changeset found

Latest commit: b124f73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-02-03T19:59:40Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`64ef708`)	Head (`9797ac1`)	Diff
browser	11.2 kB	11.2 kB	-21 B (-0.2%)
esm2017	9.60 kB	9.58 kB	-21 B (-0.2%)
lite	9.27 kB	9.25 kB	-11 B (-0.1%)
lite-esm2017	7.89 kB	7.88 kB	-11 B (-0.1%)
main	11.0 kB	10.9 kB	-21 B (-0.2%)
module	11.2 kB	11.2 kB	-21 B (-0.2%)
react-native	10.7 kB	10.6 kB	-21 B (-0.2%)

`firebase`

Type	Base (`64ef708`)	Head (`9797ac1`)	Diff
firebase-app.js	20.1 kB	20.1 kB	-15 B (-0.1%)
firebase-performance-standalone.es2017.js	71.8 kB	71.8 kB	-13 B (-0.0%)
firebase-performance-standalone.js	48.3 kB	48.3 kB	-13 B (-0.0%)
firebase.js	856 kB	856 kB	-15 B (-0.0%)

Test Logs

Base (64ef7087): https://github.com/firebase/firebase-js-sdk/actions/runs/534923753
Head (9797ac18): https://github.com/firebase/firebase-js-sdk/actions/runs/535224948

google-oss-bot · 2021-02-03T20:09:10Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

`_addComponent`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_addOrOverwriteComponent`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_clearComponents`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_getProvider`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_registerComponent`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_removeServiceInstance`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`deleteApp`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`getApp`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`getApps`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`initializeApp`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

22 dependencies

DEFAULT_ENTRY_NAME
ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`onLog`

Size Table

Type	Base (`64ef708`)	Head (`9797ac1`)	Diff
size	2.80 kB	2.79 kB	-15 B (-0.5%)
size-with-ext-deps	5.87 kB	5.86 kB	-15 B (-0.3%)

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`registerVersion`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`setLogLevel`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`SDK_VERSION`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

23 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
SDK_VERSION
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version
version$1

23 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
SDK_VERSION
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version
version$1

+ name
- name$e

`_DEFAULT_ENTRY_NAME`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

22 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_DEFAULT_ENTRY_NAME
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

22 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_DEFAULT_ENTRY_NAME
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_apps`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

`_components`

Dependency Table

Type Base (64ef708) Head (9797ac1) Diff

variables

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
name$e
version

21 dependencies

ERRORS
ERROR_FACTORY
PLATFORM_LOG_STRING
_apps
_components
logger
name
name$1
name$2
name$3
name$4
name$5
name$6
name$7
name$8
name$9
name$a
name$b
name$c
name$d
version

+ name
- name$e

Test Logs

Feiyang1 · 2021-02-03T21:29:47Z

packages-exp/app-exp/src/api.ts

@@ -285,7 +285,8 @@ export function onLog(
 ): void {
  if (logCallback !== null && typeof logCallback !== 'function') {
    throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT, {
-      appName: name
+      // appName isn't used in INVALID_LOG_ARGUMENT error but ErrorFactory requires it
+      appName: ''


The correct fix should be change type ErrorParams in errors.ts to

type ErrorParams = { [AppError.NO_APP]: { appName: string }, [AppError.BAD_APP_NAME]: { appName: string }, [AppError.DUPLICATE_APP]: { appName: string }, [AppError.APP_DELETED]: { appName: string }, [AppError.INVALID_APP_ARGUMENT]: { appName: string } };

hsubox76 added 2 commits February 3, 2021 11:32

Update app-compat

2b58c2f

Revert typescript bumps

f2bc2a2

hsubox76 requested review from Feiyang1 and hiranya911 as code owners February 3, 2021 19:39

hsubox76 changed the title ~~Ch app fixes~~ Syntax fixes in 'app' packages Feb 3, 2021

Feiyang1 suggested changes Feb 3, 2021

View reviewed changes

Fix ErrorParams

b124f73

hsubox76 assigned Feiyang1 Feb 10, 2021

Feiyang1 approved these changes Feb 10, 2021

View reviewed changes

hsubox76 merged commit 949c6ac into master Feb 10, 2021

hsubox76 deleted the ch-app-fixes branch February 10, 2021 18:41

firebase locked and limited conversation to collaborators Mar 13, 2021

Syntax fixes in 'app' packages #4409

Syntax fixes in 'app' packages #4409

Uh oh!

Conversation

hsubox76 commented Feb 3, 2021

Uh oh!

changeset-bot bot commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/app

firebase

Test Logs

Uh oh!

google-oss-bot commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/app-exp

_addComponent

_addOrOverwriteComponent

_clearComponents

_getProvider

_registerComponent

_removeServiceInstance

deleteApp

getApp

getApps

initializeApp

onLog

registerVersion

setLogLevel

SDK_VERSION

_DEFAULT_ENTRY_NAME

_apps

_components

Test Logs

Uh oh!

Feiyang1 Feb 3, 2021

Choose a reason for hiding this comment

Uh oh!

hsubox76 Feb 3, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Feb 3, 2021 •

edited

Loading

google-oss-bot commented Feb 3, 2021 •

edited

Loading

`@firebase/app`

`firebase`

google-oss-bot commented Feb 3, 2021 •

edited

Loading

`@firebase/app-exp`

`_addComponent`

`_addOrOverwriteComponent`

`_clearComponents`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_apps`

`_components`