Skip to content

Commit 50b2182

Browse files
authored
Firestore: add TODO comments about removing special 'missing index' test logic for multidb (#7874)
1 parent a476c46 commit 50b2182

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

.changeset/itchy-chicken-cry.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/firestore/test/integration/api/aggregation.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ apiDescribe('Count queries', persistence => {
140140
where('key1', '==', 42),
141141
where('key2', '<', 42)
142142
);
143+
// TODO(b/316359394) Remove the special logic for non-default databases
144+
// once cl/582465034 is rolled out to production.
143145
if (coll.firestore._databaseId.isDefaultDatabase) {
144146
await expect(
145147
getCountFromServer(query_)
@@ -350,6 +352,8 @@ apiDescribe('Aggregation queries', persistence => {
350352
where('key1', '==', 42),
351353
where('key2', '<', 42)
352354
);
355+
// TODO(b/316359394) Remove the special logic for non-default databases
356+
// once cl/582465034 is rolled out to production.
353357
if (coll.firestore._databaseId.isDefaultDatabase) {
354358
await expect(
355359
getAggregateFromServer(query_, {

packages/firestore/test/lite/integration.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2414,6 +2414,8 @@ describe('Count queries', () => {
24142414
where('key1', '==', 42),
24152415
where('key2', '<', 42)
24162416
);
2417+
// TODO(b/316359394) Remove the special logic for non-default databases
2418+
// once cl/582465034 is rolled out to production.
24172419
if (coll.firestore._databaseId.isDefaultDatabase) {
24182420
await expect(getCount(query_)).to.be.eventually.rejectedWith(
24192421
/index.*https:\/\/console\.firebase\.google\.com/
@@ -2721,6 +2723,8 @@ describe('Aggregate queries', () => {
27212723
where('key1', '==', 42),
27222724
where('key2', '<', 42)
27232725
);
2726+
// TODO(b/316359394) Remove the special logic for non-default databases
2727+
// once cl/582465034 is rolled out to production.
27242728
if (coll.firestore._databaseId.isDefaultDatabase) {
27252729
await expect(
27262730
getAggregate(query_, {

0 commit comments

Comments
 (0)