Firestore: add TODO comments about removing special 'missing index' test logic for multidb #7874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6007df5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dconeybe
changed the title
Changeset File Check
|
Size Report 1Affected ProductsNo changes between base commit (a476c46) and merge commit (725209b).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (a476c46) and merge commit (725209b).Test Logs |
milaGGL
reviewed
Dec 14, 2023
| @@ -0,0 +1,2 @@ | |||
| --- | |||
There was a problem hiding this comment.
That was intentional. There is no changeset needed and GitHub complained that there was no changeset, suggesting to create an empty changeset if no change log entry was needed. Maybe I misunderstood that message. I'll verify.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a comment to Firestore's integration tests about removing special logic when testing for the "missing index" error message. Formerly, the "missing index" error message was different for the default database and a non-default database; however, their logic has been unified, and will be rolled out to production soon. Once rolled out, these tests should be updated to remove the special logic for non-default dbs.
A similar change was made to the android sdk in firebase/firebase-android-sdk#5600.
Googlers see b/316359394 for details.