Firestore: add TODO comments about removing special 'missing index' test logic for multidb #5600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est logic for multidb
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected ProductsNo changes between base commit (ff6cc57) and merge commit (2f1fde2).Test Logs |
Unit Test Results 180 files + 144 180 suites +144 4m 5s ⏱️ + 3m 12s Results for commit f92d45f. ± Comparison against base commit ff6cc57. This pull request removes 157 and adds 1226 tests. Note that renamed tests count towards both. |
Size Report 1Affected ProductsNo changes between base commit (ff6cc57) and merge commit (2f1fde2).Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a comment to Firestore's integration tests about removing special logic when testing for the "missing index" error message. Formerly, the "missing index" error message was different for the default database and a non-default database; however, their logic has been unified, and will be rolled out to production soon. Once rolled out, these tests should be updated to remove the special logic for non-default dbs.
Also, remove the "else" branch that verified a different error message when a non-default db was used because when that change rolls out that "else" block will start to fail, seemingly without reason. This also brings the test into parity with the js sdk.
A similar change was made to the js sdk in firebase/firebase-js-sdk#7874.
Googlers see b/316359394 for details.