Skip to content

Commit 5d67b57

Browse files
authored
Remove Promise from FirebaseNamespace (#1741)
* Remove Promsie from FirebaseNamespae * remove the test case that checks promise
1 parent a0605e6 commit 5d67b57

File tree

3 files changed

+0
-26
lines changed

3 files changed

+0
-26
lines changed

integration/shared/namespaceDefinition.json

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -38,26 +38,6 @@
3838
"apps": {
3939
"__type": "array"
4040
},
41-
"Promise": {
42-
"__type": "function",
43-
"resolve": {
44-
"__type": "function"
45-
},
46-
"reject": {
47-
"__type": "function"
48-
},
49-
"all": {
50-
"__type": "function"
51-
},
52-
"prototype": {
53-
"then": {
54-
"__type": "function"
55-
},
56-
"catch": {
57-
"__type": "function"
58-
}
59-
}
60-
},
6141
"INTERNAL": {
6242
"__type": "object",
6343
"registerService": {

packages/app-types/index.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ export interface FirebaseNamespace {
9898
*/
9999
apps: FirebaseApp[];
100100

101-
// Inherit the type information of our exported Promise implementation from
102-
// es6-promises.
103-
Promise: typeof Promise;
104-
105101
// The current SDK version.
106102
SDK_VERSION: string;
107103
}

packages/app/src/firebaseNamespaceCore.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export function createFirebaseNamespaceCore(
6262
initializeApp: initializeApp,
6363
app: app as any,
6464
apps: null as any,
65-
Promise: Promise,
6665
SDK_VERSION: '${JSCORE_VERSION}',
6766
INTERNAL: {
6867
registerService,
@@ -244,7 +243,6 @@ export function createFirebaseNamespaceCore(
244243
}
245244

246245
const useService = name;
247-
const options = app.options;
248246

249247
return useService;
250248
}

0 commit comments

Comments
 (0)