Skip to content

Remove Promise from FirebaseNamespace #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2019
Merged

Remove Promise from FirebaseNamespace #1741

merged 2 commits into from
May 2, 2019

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented May 1, 2019

Removing legacy code.

@mmermerkaya mmermerkaya changed the title Remove Promsie from FirebaseNamespae Remove Promise from FirebaseNamespace May 2, 2019
@Feiyang1 Feiyang1 merged commit 5d67b57 into master May 2, 2019
@Feiyang1 Feiyang1 deleted the fei-appcleanup branch May 2, 2019 17:22
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feiyang1 @hsubox76