Skip to content

Commit 664b82c

Browse files
committed
Merge branch 'release' into master-io
2 parents 5d67b57 + fb75607 commit 664b82c

File tree

11 files changed

+30
-14
lines changed

11 files changed

+30
-14
lines changed

integration/browserify/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"test": "karma start --single-run"
88
},
99
"dependencies": {
10-
"firebase": "5.11.0"
10+
"firebase": "5.11.1"
1111
},
1212
"devDependencies": {
1313
"@babel/core": "7.4.3",

integration/firebase-typings/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"test": "tsc index.ts --outDir dist"
77
},
88
"dependencies": {
9-
"firebase": "5.11.0"
9+
"firebase": "5.11.1"
1010
},
1111
"devDependencies": {
1212
"typescript": "3.4.5"

integration/messaging/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"test:manual": "mocha --exit"
99
},
1010
"dependencies": {
11-
"firebase": "5.11.0"
11+
"firebase": "5.11.1"
1212
},
1313
"devDependencies": {
1414
"chai": "4.2.0",

integration/typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"test": "karma start --single-run"
77
},
88
"dependencies": {
9-
"firebase": "5.11.0"
9+
"firebase": "5.11.1"
1010
},
1111
"devDependencies": {
1212
"@babel/core": "7.4.3",

integration/webpack/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"test": "karma start --single-run"
88
},
99
"dependencies": {
10-
"firebase": "5.11.0"
10+
"firebase": "5.11.1"
1111
},
1212
"devDependencies": {
1313
"@babel/core": "7.4.3",

packages/firebase/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "firebase",
3-
"version": "5.11.0",
3+
"version": "5.11.1",
44
"description": "Firebase JavaScript library for web and Node.js",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"license": "Apache-2.0",
@@ -45,7 +45,7 @@
4545
"@firebase/messaging": "0.3.19",
4646
"@firebase/polyfill": "0.3.13",
4747
"@firebase/storage": "0.2.15",
48-
"@firebase/performance": "0.2.0"
48+
"@firebase/performance": "0.2.1"
4949
},
5050
"devDependencies": {
5151
"git-rev-sync": "1.12.0",

packages/performance/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/performance",
3-
"version": "0.2.0",
3+
"version": "0.2.1",
44
"description": "Firebase performance for web",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",

packages/performance/src/services/remote_config_service.test.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,5 +176,21 @@ describe('Performance Monitoring > remote_config_service', () => {
176176

177177
expect(SettingsService.getInstance().loggingEnabled).to.be.true;
178178
});
179+
180+
it('uses secondary configs if the response does not have any fields', async () => {
181+
// Expired local config.
182+
const EXPIRY_LOCAL_STORAGE_VALUE = '1556524895320';
183+
storageGetItemStub.callsFake(
184+
storageGetItemFakeFactory(
185+
EXPIRY_LOCAL_STORAGE_VALUE,
186+
'not a valid config and should not be used'
187+
)
188+
);
189+
const STRINGIFIED_PARTIAL_CONFIG = '{"state":"NO TEMPLATE"}';
190+
fetchStub.resolves(new Response(STRINGIFIED_PARTIAL_CONFIG));
191+
await getConfig(IID);
192+
193+
expect(SettingsService.getInstance().loggingEnabled).to.be.true;
194+
});
179195
});
180196
});

packages/performance/src/services/remote_config_service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ function getRemoteConfig(
147147
function processConfig(
148148
config: RemoteConfigResponse | undefined
149149
): RemoteConfigResponse | undefined {
150-
if (!config || !config.entries) return config;
150+
if (!config) return config;
151151
const settingsServiceInstance = SettingsService.getInstance();
152-
const entries = config.entries;
152+
const entries = config.entries || {};
153153
if (entries.fpr_enabled !== undefined) {
154154
// TODO: Change the assignment of loggingEnabled once the received type is known.
155155
settingsServiceInstance.loggingEnabled =

packages/rxfire/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "rxfire",
3-
"version": "3.4.2",
3+
"version": "3.4.3",
44
"private": false,
55
"description": "Firebase JavaScript library RxJS",
66
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
@@ -36,7 +36,7 @@
3636
"rxjs": "6.x.x"
3737
},
3838
"devDependencies": {
39-
"firebase": "5.11.0",
39+
"firebase": "5.11.1",
4040
"rxjs": "^6.5.1",
4141
"rollup": "1.10.1",
4242
"rollup-plugin-commonjs": "9.3.4",

packages/testing/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/testing",
3-
"version": "0.9.0",
3+
"version": "0.9.1",
44
"description": "",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",
@@ -15,7 +15,7 @@
1515
},
1616
"license": "Apache-2.0",
1717
"dependencies": {
18-
"firebase": "5.11.0",
18+
"firebase": "5.11.1",
1919
"@firebase/logger": "0.1.13",
2020
"@firebase/util": "0.2.14",
2121
"@types/request": "2.48.1",

0 commit comments

Comments
 (0)