Fix for Fireperf counter value might be null (#5903)

* Fix trace putMetric(...) and record(...) to not put null values in counter values map

Author: jfcong

packages/performance/src/resources/trace.test.ts

@@ -134,6 +134,15 @@ describe('Firebase Performance > trace', () => {
       expect(trace.getAttributes()).to.eql({ level: '1' });
       expect(trace.getMetric('cacheHits')).to.eql(1);
     });
+
+    it('does not log counter with invalid counter value', () => {
+      trace.record(1, 20, {
+        metrics: { level: NaN }
+      });
+
+      expect((perfLogger.logTrace as any).calledOnceWith(trace)).to.be.true;
+      expect(trace.getMetric('level')).to.eql(0);
+    });
   });
 
   describe('#incrementMetric', () => {
@@ -189,6 +198,12 @@ describe('Firebase Performance > trace', () => {
       expect(trace.getMetric('cacheHits')).to.eql(400);
     });
 
+    it('replaces undefined metrics with 0', () => {
+      trace.putMetric('cacheHits', undefined);
+
+      expect(trace.getMetric('cacheHits')).to.eql(0);
+    });
+
     it('throws error if metric doesnt exist and has invalid name', () => {
       expect(() => trace.putMetric('_invalidMetric', 1)).to.throw();
       expect(() => trace.putMetric('_fid', 1)).to.throw();

packages/performance/src/resources/trace.ts

@@ -151,9 +151,11 @@ export class Trace implements PerformanceTrace {
       this.customAttributes = { ...options.attributes };
     }
     if (options && options.metrics) {
-      for (const metric of Object.keys(options.metrics)) {
-        if (!isNaN(Number(options.metrics[metric]))) {
-          this.counters[metric] = Number(Math.floor(options.metrics[metric]));
+      for (const metricName of Object.keys(options.metrics)) {
+        if (!isNaN(Number(options.metrics[metricName]))) {
+          this.counters[metricName] = Math.floor(
+            Number(options.metrics[metricName])
+          );
         }
       }
     }
@@ -183,7 +185,7 @@ export class Trace implements PerformanceTrace {
    */
   putMetric(counter: string, numAsInteger: number): void {
     if (isValidMetricName(counter, this.name)) {
-      this.counters[counter] = convertMetricValueToInteger(numAsInteger);
+      this.counters[counter] = convertMetricValueToInteger(numAsInteger ?? 0);
     } else {
       throw ERROR_FACTORY.create(ErrorCode.INVALID_CUSTOM_METRIC_NAME, {
         customMetricName: counter