Skip to content

Fix for Fireperf counter value might be null #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 27, 2022
Merged

Fix for Fireperf counter value might be null #5903

merged 6 commits into from
Jan 27, 2022

Conversation

jfcong
Copy link
Contributor

@jfcong jfcong commented Jan 19, 2022

Fix for Fireperf counter value might be null

@jfcong jfcong requested a review from jposuna as a code owner January 19, 2022 19:17
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5822772

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jfcong jfcong marked this pull request as draft January 19, 2022 19:29
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth-compat

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser20.0 kB20.1 kB+83 B (+0.4%)
    esm526.9 kB26.9 kB+87 B (+0.3%)
    main29.4 kB29.5 kB+87 B (+0.3%)
    module20.0 kB20.1 kB+83 B (+0.4%)

  • @firebase/auth/cordova

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser180 kB180 kB+28 B (+0.0%)
    module180 kB180 kB+28 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser163 kB163 kB+12 B (+0.0%)
    esm5212 kB212 kB+28 B (+0.0%)
    main179 kB179 kB+28 B (+0.0%)
    module163 kB163 kB+12 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser163 kB164 kB+893 B (+0.5%)
    module163 kB164 kB+893 B (+0.5%)

  • @firebase/firestore

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser228 kB229 kB+1.01 kB (+0.4%)
    esm5285 kB286 kB+1.09 kB (+0.4%)
    main453 kB455 kB+1.55 kB (+0.3%)
    module228 kB229 kB+1.01 kB (+0.4%)
    react-native228 kB229 kB+1.01 kB (+0.4%)

  • @firebase/performance

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    browser28.4 kB28.5 kB+61 B (+0.2%)
    esm530.1 kB30.2 kB+61 B (+0.2%)
    main30.6 kB30.6 kB+61 B (+0.2%)
    module28.4 kB28.5 kB+61 B (+0.2%)

  • bundle

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    firestore (Persistence)229 kB230 kB+274 B (+0.1%)
    firestore (Query Cursors)189 kB189 kB+274 B (+0.1%)
    firestore (Query)190 kB190 kB+274 B (+0.1%)
    firestore (Read data once)178 kB179 kB+274 B (+0.2%)
    firestore (Realtime updates)181 kB181 kB+274 B (+0.2%)
    firestore (Transaction)163 kB163 kB+274 B (+0.2%)
    firestore (Write data)162 kB163 kB+274 B (+0.2%)
    performance (trace)42.3 kB42.3 kB+23 B (+0.1%)

  • firebase

    11 size changes

    TypeBase (4dd6aba)Merge (3b47bd8)Diff
    firebase-auth-compat.js123 kB123 kB-29 B (-0.0%)
    firebase-auth-cordova.js91 B462 kB+462 kB (+508079.1%)
    firebase-auth-react-native.js101 B486 kB+486 kB (+480885.1%)
    firebase-auth.js411 kB411 kB+12 B (+0.0%)
    firebase-compat.js753 kB754 kB+253 B (+0.0%)
    firebase-firestore-compat.js281 kB281 kB+272 B (+0.1%)
    firebase-firestore.js770 kB772 kB+2.36 kB (+0.3%)
    firebase-performance-compat.js30.8 kB30.8 kB+10 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js78.9 kB78.9 kB+10 B (+0.0%)
    firebase-performance-standalone-compat.js57.0 kB57.0 kB+10 B (+0.0%)
    firebase-performance.js119 kB119 kB+71 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sQRUmLaAPu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (337,127 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DKBJevFBSx.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@jfcong
Copy link
Contributor Author

jfcong commented Jan 22, 2022

changeset add

@jfcong jfcong marked this pull request as ready for review January 26, 2022 22:58
@jfcong jfcong requested a review from jposuna January 26, 2022 22:59
jposuna
jposuna approved these changes Jan 27, 2022
View reviewed changes
packages/performance/src/resources/trace.ts Outdated
this.counters[counter] =
numAsInteger === undefined
? 0
: convertMetricValueToInteger(numAsInteger);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can simplify this to:

this.counters[counter] = convertMetricValueToInteger(numAsInteger ?? 0);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@jfcong jfcong merged commit 73fcec9 into master Jan 27, 2022
@jfcong jfcong deleted the null-counter-value branch January 27, 2022 20:19
@firebase firebase locked and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jposuna jposuna jposuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfcong @google-oss-bot @jposuna