Allow leading zeros in tryParseInt (#2212)

Author: schmidt-sebastian

packages/database/CHANGELOG.md

@@ -1,4 +1,7 @@
 # Unreleased
+- [fixed] Fixed an issue that caused large numeric values with leading zeros to
+  not always be sorted correctly.
+
 - [changed] Internal cleanup to Node.JS support.
 
 # 6.4.0

packages/database/src/core/util/util.ts

@@ -546,7 +546,7 @@ export const errorForServerCode = function(code: string, query: Query): Error {
  * @type {RegExp}
  * @private
  */
-export const INTEGER_REGEXP_ = new RegExp('^-?\\d{1,10}$');
+export const INTEGER_REGEXP_ = new RegExp('^-?(0*)\\d{1,10}$');
 
 /**
  * If the string contains a 32-bit integer, return it.  Else return null.

packages/database/test/path.test.ts

@@ -20,8 +20,12 @@ import { Path } from '../src/core/util/Path';
 
 describe('Path Tests', function() {
   const expectGreater = function(left, right) {
-    expect(Path.comparePaths(new Path(left), new Path(right))).to.equal(1);
-    expect(Path.comparePaths(new Path(right), new Path(left))).to.equal(-1);
+    expect(
+      Path.comparePaths(new Path(left), new Path(right))
+    ).to.be.greaterThan(0);
+    expect(Path.comparePaths(new Path(right), new Path(left))).to.be.lessThan(
+      0
+    );
   };
 
   const expectEqual = function(left, right) {
@@ -117,5 +121,7 @@ describe('Path Tests', function() {
     expectGreater('/ab', '/a');
     expectGreater('/a/b', '/a');
     expectGreater('/a/b', '/a//');
+    expectGreater('/a/0971500000', '/a/00403311635');
+    expectGreater('/a/0971500000', '/a/971500000');
   });
 });