Allow leading zeros in tryParseInt #2212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdt
reviewed
Sep 30, 2019
Co-Authored-By: Jeffrey Dallatezza <[email protected]>
mikelehen
reviewed
Sep 30, 2019
packages/database/test/path.test.ts
Outdated
| @@ -20,8 +20,8 @@ import { Path } from '../src/core/util/Path'; | |||
|
|
|||
| describe('Path Tests', function() { | |||
| const expectGreater = function(left, right) { | |||
| expect(Path.comparePaths(new Path(left), new Path(right))).to.equal(1); | |||
| expect(Path.comparePaths(new Path(right), new Path(left))).to.equal(-1); | |||
| expect(Path.comparePaths(new Path(left), new Path(right))).to.be.greaterThan(0) | |||
There was a problem hiding this comment.
Well, on GitHub it is missing. But I swear that I have this locally (via the Prettier commit that once again got stuck somewhere...)
…-js-sdk into mrschmidt/leadingzeros
mikelehen
approved these changes
Sep 30, 2019
|
CI is passing now after a re-run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://buganizer.corp.google.com/issues/141298281
A customer noticed that we don't correctly order their documents. Some of their documents are using keys of the form "00x", where x is a 9 digit number. Our number check only allows for ten digits, and leading zeros can break this limit. This PR relaxes the check and matches the backend semantics.