Remove asserts again

Author: schmidt-sebastian

packages/firestore/src/model/document.ts

@@ -259,7 +259,7 @@ export class MutableDocument implements Document {
 
   setHasCommittedMutations(): MutableDocument {
     debugAssert(
-      !this.isValidDocument(),
+      this.isValidDocument(),
       'Invalid documents cannot have committed mutations'
     );
     this.documentState = DocumentState.HAS_COMMITTED_MUTATIONS;

packages/firestore/src/model/mutation.ts

@@ -410,10 +410,11 @@ function applySetMutationToLocalView(
   document: MutableDocument,
   localWriteTime: Timestamp
 ): void {
-  debugAssert(
-    mutation.precondition.isNone,
-    'SetMutations should not have preconditions outside of Transactions'
-  );
+  if (!preconditionIsValidForDocument(mutation.precondition, document)) {
+    // The mutation failed to apply (e.g. a document ID created with add()
+    // caused a name collision).
+    return;
+  }
 
   const newData = mutation.value.clone();
   const transformResults = localTransformResults(
@@ -626,14 +627,11 @@ function applyDeleteMutationToLocalView(
     document.key.isEqual(mutation.key),
     'Can only apply mutation to document with same key'
   );
-  debugAssert(
-    mutation.precondition.isNone,
-    'DeleteMutions should not have preconditions outside of Transactions'
-  );
-
-  // We don't call `setHasLocalMutations()` since we want to be backwards
-  // compatible with the existing SDK behavior.
-  document.convertToNoDocument(SnapshotVersion.min());
+  if (preconditionIsValidForDocument(mutation.precondition, document)) {
+    // We don't call `setHasLocalMutations()` since we want to be backwards
+    // compatible with the existing SDK behavior.
+    document.convertToNoDocument(SnapshotVersion.min());
+  }
 }
 
 /**