Skip to content

Commit 8e9604f

Browse files
authored
Make AuthInternal implement the interface (#4000)
1 parent a9ba7ba commit 8e9604f

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

common/api-review/functions-exp.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function getFunctions(app: FirebaseApp, regionOrCustomDomain?: string): F
1616
export function httpsCallable(functionsInstance: Functions, name: string, options?: HttpsCallableOptions): HttpsCallable;
1717

1818
// @public
19-
export function useFunctionsEmulator(functionsInstance: Functions, origin: string): void;
19+
export function useFunctionsEmulator(functionsInstance: Functions, host: string, port: number): void;
2020

2121

2222
// (No @packageDocumentation comment for this package)

packages-exp/auth-exp/src/core/auth/firebase_internal.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,16 @@
1616
*/
1717

1818
import { Unsubscribe } from '@firebase/util';
19+
import { FirebaseAuthInternal } from '@firebase/auth-interop-types';
1920

2021
import { Auth } from '../../model/auth';
2122
import { User } from '../../model/user';
2223

23-
declare module '@firebase/component' {
24-
interface NameServiceMapping {
25-
'auth-internal-exp': AuthInternal;
26-
}
27-
}
28-
2924
interface TokenListener {
3025
(tok: string | null): unknown;
3126
}
3227

33-
export class AuthInternal {
28+
export class AuthInternal implements FirebaseAuthInternal {
3429
private readonly internalListeners: Map<
3530
TokenListener,
3631
Unsubscribe

packages-exp/auth-exp/src/core/auth/register.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import {
3333
import { AuthInternal } from './firebase_internal';
3434

3535
export const _AUTH_COMPONENT_NAME = 'auth-exp';
36-
export const _AUTH_INTERNAL_COMPONENT_NAME = 'auth-internal-exp';
36+
export const _AUTH_INTERNAL_COMPONENT_NAME = 'auth-internal';
3737

3838
function getVersionForPlatform(
3939
clientPlatform: ClientPlatform

0 commit comments

Comments
 (0)