Skip to content

Make AuthInternal implement the interface #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

Feiyang1
Copy link
Member

  • Implement the interface from @firebase/auth-interop-types
  • rename the internal component to auth-internal, so consumers don't need to change their existing code for exp. (It's also easier for the typings).

FYI, @schmidt-sebastian

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2020

⚠️ No Changeset found

Latest commit: e514ed7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (a9ba7ba) and head commit (699d8b4).

Test Logs

@Feiyang1 Feiyang1 merged commit 8e9604f into master Oct 27, 2020
@Feiyang1 Feiyang1 deleted the fei-auth-internal-exp branch October 27, 2020 21:14
@firebase firebase locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants