Skip to content

Make AuthInternal implement the interface #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Make AuthInternal implement the interface #4000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/api-review/functions-exp.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function getFunctions(app: FirebaseApp, regionOrCustomDomain?: string): F
export function httpsCallable(functionsInstance: Functions, name: string, options?: HttpsCallableOptions): HttpsCallable;

// @public
export function useFunctionsEmulator(functionsInstance: Functions, origin: string): void;
export function useFunctionsEmulator(functionsInstance: Functions, host: string, port: number): void;


// (No @packageDocumentation comment for this package)
Expand Down
9 changes: 2 additions & 7 deletions packages-exp/auth-exp/src/core/auth/firebase_internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,16 @@
*/

import { Unsubscribe } from '@firebase/util';
import { FirebaseAuthInternal } from '@firebase/auth-interop-types';

import { Auth } from '../../model/auth';
import { User } from '../../model/user';

declare module '@firebase/component' {
interface NameServiceMapping {
'auth-internal-exp': AuthInternal;
}
}

interface TokenListener {
(tok: string | null): unknown;
}

export class AuthInternal {
export class AuthInternal implements FirebaseAuthInternal {
private readonly internalListeners: Map<
TokenListener,
Unsubscribe
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/auth-exp/src/core/auth/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {
import { AuthInternal } from './firebase_internal';

export const _AUTH_COMPONENT_NAME = 'auth-exp';
export const _AUTH_INTERNAL_COMPONENT_NAME = 'auth-internal-exp';
export const _AUTH_INTERNAL_COMPONENT_NAME = 'auth-internal';

function getVersionForPlatform(
clientPlatform: ClientPlatform
Expand Down