Skip to content

Commit 99e35d6

Browse files
committed
address comments
1 parent b2ac830 commit 99e35d6

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/e2e-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Yarn install
6262
run: |
6363
echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}"
64-
yarn add firebase@11.8.1
64+
yarn add firebase@${{ github.event.client_payload.versionOrTag }}
6565
yarn
6666
- name: Deploy "callTest" cloud function
6767
run: |

e2e/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# E2E Tests
22

3-
This directory is for Firebase E2E tests that are completely independent of the main SDK workspaces. Packages in here should
3+
This directory is for Firebase E2E tests that are completely independent of the main SDK workspaces. Packages in here should:
44

55
* Have a start trigger independent of the main CI PR/push triggers (e.g., manual trigger, repository_dispatch, from an external runner like Kokoro, etc.)
66

e2e/smoke-tests/sample-apps/compat.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ async function authLogout() {
8282
*
8383
* Call a deployed function.
8484
* This cloud function must be deployed in this project first. See
85-
* s/README.md for more info.
85+
* e2e/smoke-test/README.md for more info.
8686
*/
8787
async function callFunctions() {
8888
console.log('[FUNCTIONS] start');

0 commit comments

Comments
 (0)