Skip to content

Commit b0d5374

Browse files
authored
Run 'Firestore Integration Tests' jobs in parallel (#7558)
1 parent 4decdf6 commit b0d5374

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

.github/workflows/test-all.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,11 @@ jobs:
186186
continue-on-error: true
187187

188188
test-firestore-integration:
189-
name: Firestore Integration Tests
189+
strategy:
190+
fail-fast: false
191+
matrix:
192+
persistence: ['memory', 'persistence']
193+
name: Firestore Integration Tests (${{ matrix.persistence }})
190194
needs: build
191195
runs-on: ubuntu-latest
192196
steps:
@@ -207,15 +211,11 @@ jobs:
207211
node-version: 16.x
208212
- name: Bump Node memory limit
209213
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
210-
- name: Test setup and yarn install
211-
run: |
212-
cp config/ci.config.json config/project.json
213-
yarn
214-
- name: Set start timestamp env var
215-
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
216-
- name: Run unit tests
217-
run: |
218-
xvfb-run yarn lerna run --concurrency 4 test:ci --scope firebase-firestore-integration-test
219-
node scripts/print_test_logs.js
214+
- run: cp config/ci.config.json config/project.json
215+
- run: yarn
216+
- run: yarn build:${{ matrix.persistence }}
217+
working-directory: integration/firestore
218+
- run: xvfb-run yarn karma:singlerun
219+
working-directory: integration/firestore
220220
env:
221221
FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

integration/firestore/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
"build:deps": "lerna run --scope @firebase/'{app,firestore}' --include-dependencies build",
77
"build:persistence": "INCLUDE_FIRESTORE_PERSISTENCE=true gulp compile-tests",
88
"build:memory": "INCLUDE_FIRESTORE_PERSISTENCE=false gulp compile-tests",
9+
"karma:singlerun": "karma start --single-run",
910
"prettier": "prettier --write '*.js' '*.ts'",
10-
"test": "yarn build:memory; karma start --single-run; yarn build:persistence; karma start --single-run;",
11-
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test",
1211
"test:persistence": " yarn build:persistence; karma start --single-run",
1312
"test:persistence:debug": "yarn build:persistence; karma start --auto-watch --browsers Chrome",
1413
"test:memory": "yarn build:memory; karma start --single-run",

0 commit comments

Comments
 (0)