Firestore: Run 'Firestore Integration Tests' jobs in parallel #7558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected ProductsNo changes between base commit (4decdf6) and merge commit (ed88874).Test Logs |
|
Size Analysis Report 1Affected ProductsNo changes between base commit (4decdf6) and merge commit (4c2f06f).Test Logs |
dconeybe
commented
Aug 16, 2023
.github/workflows/test-all.yml
Outdated
| - name: Run unit tests | ||
| run: | | ||
| xvfb-run yarn lerna run --concurrency 4 test:ci --scope '@firebase/firestore*' |
There was a problem hiding this comment.
NOTE TO SELF: This also needs to test the other packages, like firestore-compat
dconeybe
changed the title
wu-hui
approved these changes
Aug 17, 2023
|
@hsubox76 @DellaBitta Could one of you take a look at this PR? I think it needs your approval to merge. |
DellaBitta
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit
test-all.ymlto run theFirestore Integration Testsjob differently. Previously, it calledrun_tests_in_ci.jsto run the tests; however, this "wrapper" script has issues where the log output is truncated, making it virtually impossible to debug test failures, or even know which tests are failing. After struggling with a fix for the truncation issue (#7553) we eventually gave up and instead just create one job per npm script that gets run. This has a few benefits, not the least of which is the tests truly running in parallel but also does not lead to truncated logs.This PR is heavily based on a similar change to other Firestore github actions checks: #7523