Skip to content

Firestore: Run 'Firestore Integration Tests' jobs in parallel #7558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 17, 2023
Merged

Firestore: Run 'Firestore Integration Tests' jobs in parallel #7558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c6173a5
integration/api/aggregation.test.ts: force a test to fail
dconeybe Aug 15, 2023
751eb16
integration/remote/stream.test.ts: force a test to fail
dconeybe Aug 15, 2023
d957a43
test-all.yml: Call karma directly for the 'Firestore Integration Test…
dconeybe Aug 15, 2023
661ec66
test-all.yml: run karma via yarn, instead of directly (which doesn't …
dconeybe Aug 15, 2023
f9ef5a6
test-all.yml: set fail-fast=false
dconeybe Aug 15, 2023
e6401aa
test-all.yml: use a matrix for firestore tests as well
dconeybe Aug 15, 2023
94dcd80
show full output from mocha and karma in CI
dconeybe Aug 15, 2023
c8de55f
remove test script
dconeybe Aug 16, 2023
e7a9f37
Remove setting FIREBASE_CI_TEST_START_TIME since it's no longer needed
dconeybe Aug 16, 2023
c0fecba
Revert "integration/api/aggregation.test.ts: force a test to fail"
dconeybe Aug 16, 2023
d057035
Revert "integration/remote/stream.test.ts: force a test to fail"
dconeybe Aug 16, 2023
8a5799f
Merge remote-tracking branch 'origin/master' into CILogTruncationFix
dconeybe Aug 17, 2023
70a655d
Revert changes to "(Firestore) Node.js and Browser (Chrome) Tests" jo…
dconeybe Aug 17, 2023
4bd6e0e
test-all.yml cleanup
dconeybe Aug 17, 2023
0ccc5d8
use working-directory
dconeybe Aug 17, 2023
ddaec15
collapse two commands
dconeybe Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,11 @@ jobs:
continue-on-error: true

test-firestore-integration:
name: Firestore Integration Tests
strategy:
fail-fast: false
matrix:
persistence: ['memory', 'persistence']
name: Firestore Integration Tests (${{ matrix.persistence }})
needs: build
runs-on: ubuntu-latest
steps:
Expand All @@ -207,15 +211,11 @@ jobs:
node-version: 16.x
- name: Bump Node memory limit
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
yarn
- name: Set start timestamp env var
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
- name: Run unit tests
run: |
xvfb-run yarn lerna run --concurrency 4 test:ci --scope firebase-firestore-integration-test
node scripts/print_test_logs.js
- run: cp config/ci.config.json config/project.json
- run: yarn
- run: yarn build:${{ matrix.persistence }}
working-directory: integration/firestore
- run: xvfb-run yarn karma:singlerun
working-directory: integration/firestore
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
3 changes: 1 addition & 2 deletions integration/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
"build:deps": "lerna run --scope @firebase/'{app,firestore}' --include-dependencies build",
"build:persistence": "INCLUDE_FIRESTORE_PERSISTENCE=true gulp compile-tests",
"build:memory": "INCLUDE_FIRESTORE_PERSISTENCE=false gulp compile-tests",
"karma:singlerun": "karma start --single-run",
"prettier": "prettier --write '*.js' '*.ts'",
"test": "yarn build:memory; karma start --single-run; yarn build:persistence; karma start --single-run;",
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test",
"test:persistence": " yarn build:persistence; karma start --single-run",
"test:persistence:debug": "yarn build:persistence; karma start --auto-watch --browsers Chrome",
"test:memory": "yarn build:memory; karma start --single-run",
Expand Down