rename prepare to build, so build is not triggered after yarn install (#1592)

* rename prepare to build, so build is not triggered after yarn install

* [AUTOMATED]: Prettier Code Styling

* build packages before running tests

Author: Feiyang1

.travis.yml

@@ -15,6 +15,7 @@ before_install:
 
 before_script:
   - cp config/ci.config.json config/project.json
+  - yarn build
 
 # Misc Addons/Configs
 dist: trusty

package.json

@@ -17,7 +17,7 @@
   ],
   "scripts": {
     "dev": "lerna run --parallel --scope @firebase/* --scope firebase --scope rxfire dev",
-    "prepare": "lerna run --scope @firebase/* --scope firebase --scope rxfire prepare",
+    "build": "lerna run --scope @firebase/* --scope firebase --scope rxfire prepare",
     "prepush": "node tools/gitHooks/prepush.js",
     "link:packages": "lerna exec --scope @firebase/* --scope firebase --scope rxfire -- yarn link",
     "stage:packages": "./scripts/prepublish.sh",

scripts/release/cli.js

@@ -31,16 +31,15 @@ const {
   getCurrentSha,
   hasDiff,
   pushUpdatesToGithub,
-  resetWorkingTree,
-  treeAtHead
+  resetWorkingTree
 } = require('./utils/git');
 const {
   packageVersionUpdate,
   releaseType: releaseTypePrompt,
   validateReadyToPush,
   validateVersions
 } = require('./utils/inquirer');
-const { reinstallDeps } = require('./utils/yarn');
+const { reinstallDeps, buildPackages } = require('./utils/yarn');
 const { runTests, setupTestDeps } = require('./utils/tests');
 const { publishToNpm } = require('./utils/npm');
 const { bannerText } = require('./utils/banner');
@@ -66,7 +65,7 @@ const { argv } = require('yargs');
      * If there are no packages that have been updated
      * skip the release cycle
      */
-    if (!await hasUpdatedPackages()) {
+    if (!(await hasUpdatedPackages())) {
       console.log('No packages need to be updated. Exiting...');
       return;
     }
@@ -155,9 +154,9 @@ const { argv } = require('yargs');
     await updateWorkspaceVersions(versions, argv.canary);
 
     /**
-     * Users can pass --skipRebuild to skip the rebuild step
+     * Users can pass --skipReinstall to skip the installation step
      */
-    if (!argv.skipRebuild) {
+    if (!argv.skipReinstall) {
       /**
        * Clean install dependencies
        */
@@ -166,6 +165,11 @@ const { argv } = require('yargs');
       await reinstallDeps();
     }
 
+    /**
+     * build packages
+     */
+    await buildPackages();
+
     /**
      * Don't do the following for canary releases:
      * - Rerun tests (this is supposed to be a representation of the sha)

scripts/release/utils/yarn.js

@@ -32,3 +32,17 @@ exports.reinstallDeps = async () => {
     throw err;
   }
 };
+
+exports.buildPackages = async () => {
+  try {
+    const spinner = ora(' Building Packages').start();
+    await spawn('yarn', ['build'], {
+      cwd: root
+    });
+    spinner.stopAndPersist({
+      symbol: '✅'
+    });
+  } catch (err) {
+    throw err;
+  }
+};