Skip to content

rename prepare to build, so build is not triggered after yarn install #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2019

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Mar 9, 2019

yarn install takes a long time at the repo level. Part of it is because we automatically trigger a build for all packages after installation. This change uncouples build script from yarn install at repo level.

@Feiyang1
Copy link
Member Author

Feiyang1 commented Mar 12, 2019

@mikelehen @schmidt-sebastian It appears neither npm nor yarn supports installing directly from github for a monorepo.
npm/npm#2974
yarnpkg/yarn#4725

This change only removes prepare script at the repo level, and I don't think installing the entire monorepo is a valid use case.
Once the subdir support is added to the tools, our packages are going to work automatically since each package still has the prepare script.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, then I'm keen to give this a go and see if it causes any problems! :)

@mikelehen mikelehen removed their assignment Mar 12, 2019
@Feiyang1 Feiyang1 merged commit c0ec7a0 into master Mar 12, 2019
@Feiyang1 Feiyang1 deleted the fei-build branch March 12, 2019 21:38
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants