Skip to content

Rename prepare to build, so build is not triggered after yarn install #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Mar 9, 2019

yarn install takes a long time at the repo level. Part of it is because we automatically trigger a build for all packages after installation. This change uncouples build script from yarn install at repo level.

@mikelehen
Copy link
Contributor

I take it this didn't work out? :-(

@schmidt-sebastian
Copy link
Contributor

Note that prepare also gets run when someone installs the SDK straight from GitHub (via npm install https://github.com/firebase/firebase-js-sdk). We probably want the compile/transpile to take place for these installs. Something to keep in mind for the next iteration of this PR :)

@mikelehen
Copy link
Contributor

Looks like the next iteration is over in #1592...

So does that mean our options are either to have "prepare" (and therefore "install" as well) build the world, or else check in built artifacts to the repo? :-/

@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants