Check if tests needed before build for the Test Auth workflow (#5056)

* Check if tests needed before build

* Add config name

* support buildAll in build_changed.ts

Co-authored-by: Feiyang1 <[email protected]>

Author: hsubox76

.github/workflows/test-changed-auth.yml

@@ -28,6 +28,6 @@ jobs:
         cp config/ci.config.json config/project.json
         yarn
     - name: build
-      run: yarn build
+      run: yarn build:changed auth --buildAll
     - name: Run tests on changed packages
       run: xvfb-run yarn test:changed auth

scripts/ci-test/build_changed.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { TestReason, getTestTasks, filterTasks } from './tasks';
+import { TestReason, getTestTasks, filterTasks, logTasks } from './tasks';
 import { spawn } from 'child-process-promise';
 import chalk from 'chalk';
 import { resolve } from 'path';
@@ -34,12 +34,16 @@ const argv = yargs.options({
     type: 'boolean',
     desc:
       'whether or not build @firebase/app-compat first. It is a hack required to build Firestore'
+  },
+  buildAll: {
+    type: 'boolean',
+    desc:
+      'if true, build all packages. Used in Test Auth workflow because Auth tests depends on the firebase package'
   }
 }).argv;
 
 const allTestConfigNames = Object.keys(testConfig);
 const inputTestConfigName = argv._[0].toString();
-const { buildAppExp, buildAppCompat } = argv;
 
 if (!inputTestConfigName) {
   throw Error(`
@@ -59,21 +63,33 @@ if (!allTestConfigNames.includes(inputTestConfigName)) {
 
 const config = testConfig[inputTestConfigName]!;
 
-buildForTests(config, buildAppExp, buildAppCompat);
+buildForTests(config, argv);
+
+interface Options {
+  buildAppExp?: boolean;
+  buildAppCompat?: boolean;
+  buildAll?: boolean;
+}
 
 async function buildForTests(
   config: TestConfig,
-  buildAppExp = false,
-  buildAppCompat = false
+  { buildAppExp = false, buildAppCompat = false, buildAll = false }: Options
 ) {
   try {
     const testTasks = filterTasks(await getTestTasks(), config);
-
+    // print tasks for info
+    logTasks(testTasks);
     if (testTasks.length === 0) {
       console.log(chalk`{green No test tasks. Skipping all builds }`);
       return;
     }
 
+    // build all and return
+    if (buildAll) {
+      await spawn('yarn', ['build'], { stdio: 'inherit', cwd: root });
+      return;
+    }
+
     // hack to build Firestore which depends on @firebase/app-exp (because of firestore exp),
     // but doesn't list it as a dependency in its package.json
     // TODO: remove once modular SDKs become official

scripts/ci-test/tasks.ts

@@ -199,3 +199,20 @@ export function filterTasks(
 
   return filteredTasks;
 }
+
+export function logTasks(testTasks: TestTask[]): void {
+  for (const task of testTasks) {
+    switch (task.reason) {
+      case TestReason.Changed:
+        console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
+        break;
+      case TestReason.Dependent:
+        console.log(
+          chalk`{yellow ${task.pkgName} (depends on modified files)}`
+        );
+        break;
+      default:
+        console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
+    }
+  }
+}

scripts/ci-test/test_changed.ts

@@ -17,7 +17,7 @@
 
 import { resolve } from 'path';
 import { spawn } from 'child-process-promise';
-import { TestReason, filterTasks, getTestTasks } from './tasks';
+import { TestReason, filterTasks, getTestTasks, logTasks } from './tasks';
 import chalk from 'chalk';
 import { argv } from 'yargs';
 import { TestConfig, testConfig } from './testConfig';
@@ -51,6 +51,8 @@ async function runTests(config: TestConfig) {
   try {
     const testTasks = filterTasks(await getTestTasks(), config);
 
+    // print tasks for info
+    logTasks(testTasks);
     if (testTasks.length === 0) {
       chalk`{green No test tasks. Skipping all tests }`;
       process.exit(0);