Skip to content

Check if tests needed before build for the Test Auth workflow #5056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

hsubox76
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2021

⚠️ No Changeset found

Latest commit: 89f53b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2021

Binary Size Report

Affected SDKs

  • @firebase/app-check

    Type Base (2e6d95a) Head (7bf137e) Diff
    browser 20.9 kB 22.3 kB +1.39 kB (+6.6%)
    esm2017 17.3 kB 18.5 kB +1.18 kB (+6.8%)
    main 20.9 kB 22.3 kB +1.39 kB (+6.6%)
    module 20.5 kB 21.9 kB +1.37 kB (+6.7%)
  • firebase

    Type Base (2e6d95a) Head (7bf137e) Diff
    firebase-app-check.js 22.2 kB 22.7 kB +551 B (+2.5%)
    firebase.js 892 kB 893 kB +553 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2021

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • getAuth

      Size Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      size
      55.5 kB
      55.5 kB
      +12 B (+0.0%)
      size-with-ext-deps
      67.5 kB
      67.6 kB
      +12 B (+0.0%)
    • indexedDBLocalPersistence

      Size Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      size
      36.8 kB
      36.8 kB
      +12 B (+0.0%)
      size-with-ext-deps
      48.0 kB
      48.1 kB
      +12 B (+0.0%)
  • @firebase/functions-exp

    • getFunctions

      Size Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      size
      2.08 kB
      2.38 kB
      +307 B (+14.8%)
      size-with-ext-deps
      7.95 kB
      8.26 kB
      +309 B (+3.9%)

      Dependency Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      variables

      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      + APP_CHECK_INTERNAL_NAME

    • httpsCallable

      Size Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      size
      5.46 kB
      5.84 kB
      +375 B (+6.9%)
      size-with-ext-deps
      10.7 kB
      11.1 kB
      +377 B (+3.5%)

      Dependency Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      variables

      DEFAULT_REGION
      FUNCTIONS_TYPE
      LONG_TYPE
      UNSIGNED_LONG_TYPE
      errorCodeMap
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      LONG_TYPE
      UNSIGNED_LONG_TYPE
      errorCodeMap
      name
      version
      

      + APP_CHECK_INTERNAL_NAME

    • useFunctionsEmulator

      Size Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      size
      2.05 kB
      2.36 kB
      +307 B (+15.0%)
      size-with-ext-deps
      6.66 kB
      6.97 kB
      +307 B (+4.6%)

      Dependency Table

      TypeBase (2e6d95a)Head (7bf137e)Diff
      variables

      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      + APP_CHECK_INTERNAL_NAME

@Feiyang1 Feiyang1 changed the title WIP: Check if tests needed before build Check if tests needed before build for the Test Auth workflow Jun 23, 2021
@Feiyang1 Feiyang1 merged commit c2d0fdc into master Jun 24, 2021
@Feiyang1 Feiyang1 deleted the ch-test-changed branch June 24, 2021 17:35
@firebase firebase locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants