Skip to content

Commit cceee46

Browse files
committed
ignore firebase and firebase-exp
1 parent f362e74 commit cceee46

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

scripts/ci-test/run_changed.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,12 @@ const specialPaths = {
8282
'packages/firestore': ['firebase-firestore-integration-test']
8383
};
8484

85+
/**
86+
* firebase and firebase-exp don't have tests and are very expensive to build, so we don't
87+
* generate TestTasks for them.
88+
*/
89+
const ignoredPackages = ['firebase', 'firebase-exp'];
90+
8591
/**
8692
* Identify modified packages that require tests.
8793
*/
@@ -97,7 +103,7 @@ export async function getTestTasks(): Promise<TestTask[]> {
97103
);
98104
const diff = await git.diff(['--name-only', 'origin/master...HEAD']);
99105
const changedFiles = diff.split('\n');
100-
const testTasks: TestTask[] = [];
106+
let testTasks: TestTask[] = [];
101107
for (const filename of changedFiles) {
102108
// Files that trigger full test suite.
103109
if (fullTestTriggerFiles.includes(filename)) {
@@ -156,12 +162,16 @@ export async function getTestTasks(): Promise<TestTask[]> {
156162
}
157163
}
158164
}
165+
159166
if (testTasks.length === 0) {
160167
console.log(
161168
chalk`{green No changes detected in any package. No test tasks is created }`
162169
);
163170
}
164171

172+
// remove ignored packages
173+
testTasks = testTasks.filter(t => !ignoredPackages.includes(t.pkgName));
174+
165175
return testTasks;
166176
}
167177

scripts/ci-test/run_changed_fcm_integration.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@
1616
*/
1717

1818
import { getTestTasks, runTests } from './run_changed';
19+
import { buildForTests } from './build';
1920

2021
const includeOnlyPackages = ['firebase-messaging-integration-test'];
2122

2223
async function run() {
2324
let testTasks = await getTestTasks();
2425
testTasks = testTasks.filter(t => includeOnlyPackages.includes(t.pkgName));
25-
26+
await buildForTests(testTasks);
2627
runTests(testTasks);
2728
}
2829

scripts/ci-test/run_changed_firestore.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717

1818
import { getTestTasks, runTests } from './run_changed';
19+
import { buildForTests } from './build';
1920

2021
const includeOnlyPackages = [
2122
'@firebase/firestore',
@@ -25,7 +26,7 @@ const includeOnlyPackages = [
2526
async function run() {
2627
let testTasks = await getTestTasks();
2728
testTasks = testTasks.filter(t => includeOnlyPackages.includes(t.pkgName));
28-
29+
await buildForTests(testTasks);
2930
runTests(testTasks);
3031
}
3132

0 commit comments

Comments
 (0)