fix various issues (#4316)

Author: Feiyang1

packages-exp/messaging-exp/rollup.config.js

@@ -42,9 +42,6 @@ const es5Builds = [
       { file: pkg.module, format: 'es', sourcemap: true }
     ],
     plugins: es5BuildPlugins,
-    treeshake: {
-      moduleSideEffects: false
-    },
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   }
 ];
@@ -73,9 +70,6 @@ const es2017Builds = [
       sourcemap: true
     },
     plugins: es2017BuildPlugins,
-    treeshake: {
-      moduleSideEffects: false
-    },
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   },
 

packages-exp/messaging-exp/rollup.config.release.js

@@ -47,7 +47,7 @@ const es5Builds = [
     ],
     plugins: es5BuildPlugins,
     treeshake: {
-      moduleSideEffects: false
+      moduleSideEffects: (id, external) => id === '@firebase/installations'
     },
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   }
@@ -81,7 +81,7 @@ const es2017Builds = [
     },
     plugins: es2017BuildPlugins,
     treeshake: {
-      moduleSideEffects: false
+      moduleSideEffects: (id, external) => id === '@firebase/installations'
     },
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   },
@@ -93,7 +93,7 @@ const es2017Builds = [
     plugins: es5BuildPlugins,
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
     treeshake: {
-      moduleSideEffects: false
+      moduleSideEffects: (id, external) => id === '@firebase/installations'
     }
   }
 ];

packages-exp/messaging-exp/src/api/onBackgroundMessage.ts

@@ -26,7 +26,7 @@ export function onBackgroundMessage(
   messaging: MessagingService,
   nextOrObserver: NextFn<MessagePayload> | Observer<MessagePayload>
 ): Unsubscribe {
-  if (!!navigator) {
+  if (self.document !== undefined) {
     throw ERROR_FACTORY.create(ErrorCode.AVAILABLE_IN_SW);
   }
 

packages-exp/messaging-exp/src/index.sw.ts

@@ -17,6 +17,7 @@
 
 import { FirebaseMessaging } from '@firebase/messaging-types-exp';
 import { registerMessaging } from './helpers/register';
+import '@firebase/installations-exp';
 
 export { onBackgroundMessage, getMessaging } from './api';
 

packages-exp/messaging-exp/src/index.ts

@@ -17,6 +17,7 @@
 
 import { FirebaseMessaging } from '@firebase/messaging-types-exp';
 import { registerMessaging } from './helpers/register';
+import '@firebase/installations-exp';
 
 export { getToken, deleteToken, onMessage, getMessaging } from './api';
 

packages-exp/messaging-exp/src/internals/requests.ts

@@ -21,7 +21,6 @@ import { SubscriptionOptions, TokenDetails } from '../interfaces/token-details';
 
 import { AppConfig } from '../interfaces/app-config';
 import { FirebaseInternalDependencies } from '../interfaces/internal-dependencies';
-import { getToken } from '@firebase/installations-exp';
 
 export interface ApiResponse {
   token?: string;
@@ -155,7 +154,7 @@ async function getHeaders({
   appConfig,
   installations
 }: FirebaseInternalDependencies): Promise<Headers> {
-  const authToken = await getToken(installations);
+  const authToken = await installations.getToken();
 
   return new Headers({
     'Content-Type': 'application/json',