Skip to content

Fix various issues in messaging-exp #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fix various issues in messaging-exp #4316

merged 1 commit into from
Jan 21, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2021

⚠️ No Changeset found

Latest commit: c8cc1f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 changed the base branch from master to cdn_sw January 21, 2021 01:00
@zwu52 zwu52 merged commit cf4b10c into cdn_sw Jan 21, 2021
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/messaging-exp

    • deleteToken

      Size Table

      TypeBase (04a0fea)Head (66ab1fd)Diff
      size
      7.52 kB
      7.51 kB
      -11 B (-0.1%)
      size-with-ext-deps
      24.2 kB
      24.2 kB
      +7 B (+0.0%)

    • getToken

      Size Table

      TypeBase (04a0fea)Head (66ab1fd)Diff
      size
      12.0 kB
      12.0 kB
      -17 B (-0.1%)
      size-with-ext-deps
      28.7 kB
      28.7 kB
      +7 B (+0.0%)

zwu52 added a commit that referenced this pull request Jan 21, 2021
@zwu52 @Feiyang1
Create FM CDN build (#4264)
f68bd3f 
* Create FM CDN build (sw)

* Refactor Build Rules

* revert index.cdn.ts for firebase-exp/app

auto formatting tool did its work but since this is not part of this PR reverting it.

* Use subdir modules instead of file name pattern

* Remove uncessray rules for sw subdir

* Update based on review

* Remove sw es5 builds

* Update packages-exp/firebase-exp/rollup.config.release.js

Co-authored-by: Feiyang <[email protected]>

* Apply suggestions from code review

Co-authored-by: Feiyang <[email protected]>

* Update packages-exp/messaging-exp/sw/package.json

Co-authored-by: Feiyang <[email protected]>

* fix various issues (#4316)

* Disabling non-functional fis stubbing

Co-authored-by: Feiyang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zwu52 zwu52 zwu52 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@zwu52 zwu52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @zwu52