Create FM CDN build #4264

zwu52 · 2021-01-05T22:43:10Z

This is for building fm sw script.

changeset-bot · 2021-01-05T22:43:13Z

⚠️ No Changeset found

Latest commit: f6b7ff9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-01-05T23:27:11Z

Size Analysis Report

Affected Products

`@firebase/analytics-exp`

`getAnalytics`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	8.98 kB	? (?)
size-with-ext-deps	?	14.2 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getAnalytics getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_getProvider _registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`isSupported`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.03 kB	? (?)
size-with-ext-deps	?	14.3 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError isSupported logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`logEvent`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	8.89 kB	? (?)
size-with-ext-deps	?	14.1 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	20 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent promiseAllSettled registerAnalytics setAbortableTimeout validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`setAnalyticsCollectionEnabled`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.05 kB	? (?)
size-with-ext-deps	?	14.3 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout setAnalyticsCollectionEnabled validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`setCurrentScreen`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.13 kB	? (?)
size-with-ext-deps	?	14.4 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout setCurrentScreen validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`setUserId`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.12 kB	? (?)
size-with-ext-deps	?	14.4 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout setUserId validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`setUserProperties`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.19 kB	? (?)
size-with-ext-deps	?	14.4 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout setUserProperties validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

`settings`

Size Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
size	?	9.02 kB	? (?)
size-with-ext-deps	?	14.3 kB	? (?)

Dependency Table

Type	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
functions	?	22 dependencies attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent initializeAnalytics insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout settings validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	22 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency Table

Module	Base (`04a0fea`)	Head (`b3acdbc`)	Diff
`@firebase/app-exp`	?	_registerComponent registerVersion	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?
`@firebase/component`	?	Component	?

@firebase/messaging-exp
- deleteToken
  Size Table
  Type Base (04a0fea) Head (b3acdbc) Diff
  size
  7.52 kB
  7.51 kB
  -11 B (-0.1%)
  size-with-ext-deps
  24.2 kB
  24.2 kB
  +7 B (+0.0%)
- getToken
  Size Table
  Type Base (04a0fea) Head (b3acdbc) Diff
  size
  12.0 kB
  12.0 kB
  -17 B (-0.1%)
  size-with-ext-deps
  28.7 kB
  28.7 kB
  +7 B (+0.0%)

Test Logs

packages-exp/firebase-exp/messaging/index.ts

packages-exp/firebase-exp/rollup.config.release.js

packages-exp/firebase-exp/rollup.config.js

packages-exp/firebase-exp/rollup.config.release.js

auto formatting tool did its work but since this is not part of this PR reverting it.

…into cdn_sw

packages-exp/firebase-exp/messaging/index.cdn.ts

packages-exp/firebase-exp/rollup.config.js

packages-exp/messaging-exp/package.json

packages-exp/messaging-exp/rollup.config.release.js

packages-exp/messaging-exp/sw/package.json

packages-exp/messaging-exp/rollup.config.js

packages-exp/firebase-exp/rollup.config.release.js

Co-authored-by: Feiyang <[email protected]>

packages-exp/messaging-exp/sw/package.json

packages-exp/messaging-exp/package.json

packages-exp/messaging-exp/rollup.config.release.js

Co-authored-by: Feiyang <[email protected]>

…into cdn_sw

Feiyang1 · 2021-01-21T20:00:26Z

packages-exp/messaging-exp/src/internals/requests.test.ts

@@ -85,7 +79,7 @@ describe('API', () => {

      expect(response).to.equal('fcm-token-from-server');
      expect(fetchStub).to.be.calledOnceWith(expectedEndpoint, expectedRequest);
-      expect(getAuthTokenStub).to.be.called;
+      // TODO: expect fis.getToken to be called. There is some issue w/ stubbing the fis module.


You should stub the installations object in firebaseDependencies instead

Create FM CDN build (sw)

cead470

zwu52 requested review from Feiyang1, hiranya911 and hsubox76 as code owners January 5, 2021 22:43

hsubox76 reviewed Jan 7, 2021

View reviewed changes

Refactor Build Rules

22198ba

zwu52 requested a review from hsubox76 January 11, 2021 23:36

revert index.cdn.ts for firebase-exp/app

007275a

auto formatting tool did its work but since this is not part of this PR reverting it.

zwu52 marked this pull request as draft January 13, 2021 18:35

zwu52 added 3 commits January 13, 2021 15:50

Use subdir modules instead of file name pattern

dccb53d

Merge branch 'cdn_sw' of https://github.com/firebase/firebase-js-sdk …

90c3b65

…into cdn_sw

Remove uncessray rules for sw subdir

d648b34

zwu52 marked this pull request as ready for review January 14, 2021 00:15

Feiyang1 reviewed Jan 20, 2021

View reviewed changes

Feiyang1 assigned zwu52 Jan 20, 2021

Update based on review

f1829cb

zwu52 requested a review from Feiyang1 January 20, 2021 18:32

zwu52 assigned Feiyang1 and unassigned zwu52 Jan 20, 2021

Feiyang1 reviewed Jan 20, 2021

View reviewed changes

packages-exp/messaging-exp/rollup.config.js Outdated Show resolved Hide resolved

Remove sw es5 builds

31210af

zwu52 requested a review from Feiyang1 January 20, 2021 22:16

Feiyang1 reviewed Jan 20, 2021

View reviewed changes

packages-exp/firebase-exp/rollup.config.release.js Outdated Show resolved Hide resolved

Update packages-exp/firebase-exp/rollup.config.release.js

2a78aaf

Co-authored-by: Feiyang <[email protected]>

Feiyang1 reviewed Jan 20, 2021

View reviewed changes

packages-exp/messaging-exp/sw/package.json Outdated Show resolved Hide resolved

packages-exp/messaging-exp/package.json Outdated Show resolved Hide resolved

packages-exp/messaging-exp/rollup.config.release.js Outdated Show resolved Hide resolved

zwu52 and others added 3 commits January 20, 2021 15:10

Apply suggestions from code review

9706b6b

Co-authored-by: Feiyang <[email protected]>

Update packages-exp/messaging-exp/sw/package.json

afaa093

Co-authored-by: Feiyang <[email protected]>

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

a20e776

…into cdn_sw

zwu52 requested a review from Feiyang1 January 20, 2021 23:37

zwu52 and others added 3 commits January 20, 2021 17:05

Merge branch 'cdn_sw' of https://github.com/firebase/firebase-js-sdk …

a6ed16d

…into cdn_sw

fix various issues (#4316)

cf4b10c

Merge branch 'cdn_sw' of https://github.com/firebase/firebase-js-sdk …

f99c052

…into cdn_sw

Feiyang1 approved these changes Jan 21, 2021

View reviewed changes

Disabling non-functional fis stubbing

f6b7ff9

Feiyang1 reviewed Jan 21, 2021

View reviewed changes

zwu52 merged commit f68bd3f into master Jan 21, 2021

firebase locked and limited conversation to collaborators Feb 21, 2021

Create FM CDN build #4264

Create FM CDN build #4264

Uh oh!

Conversation

zwu52 commented Jan 5, 2021

Uh oh!

changeset-bot bot commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/analytics-exp

getAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setCurrentScreen

setUserId

setUserProperties

settings

@firebase/messaging-exp

deleteToken

getToken

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feiyang1 Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Jan 5, 2021 •

edited

Loading

google-oss-bot commented Jan 5, 2021 •

edited

Loading

`@firebase/analytics-exp`

`getAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setCurrentScreen`

`setUserId`

`setUserProperties`

`settings`

`@firebase/messaging-exp`

`deleteToken`

`getToken`