Fix tests

Author: mmermerkaya

packages/app/test/firebaseApp.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import './setup';
+
 import { FirebaseApp, FirebaseNamespace } from '@firebase/app-types';
 import {
   _FirebaseApp,

packages/app/test/setup.ts

@@ -0,0 +1,6 @@
+// https://github.com/TypeStrong/ts-node#help-my-types-are-missing
+/// <reference types="../declarations" />
+
+import { root } from '@firebase/util';
+
+root.__JSCORE_VERSION__ = '__JSCORE_VERSION__';

packages/installations/src/api/create-installation.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { SinonStub, stub } from 'sinon';
 import { CreateInstallationResponse } from '../interfaces/api-response';
@@ -25,7 +27,6 @@ import {
 } from '../interfaces/installation-entry';
 import { compareHeaders } from '../testing/compare-headers';
 import { getFakeAppConfig } from '../testing/get-fake-app';
-import '../testing/setup';
 import {
   INSTALLATIONS_API_URL,
   INTERNAL_AUTH_VERSION,

packages/installations/src/api/delete-installation.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { SinonStub, stub } from 'sinon';
 import { AppConfig } from '../interfaces/app-config';
@@ -24,7 +26,6 @@ import {
 } from '../interfaces/installation-entry';
 import { compareHeaders } from '../testing/compare-headers';
 import { getFakeAppConfig } from '../testing/get-fake-app';
-import '../testing/setup';
 import {
   INSTALLATIONS_API_URL,
   INTERNAL_AUTH_VERSION

packages/installations/src/api/generate-auth-token.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { SinonStub, stub } from 'sinon';
 import { GenerateAuthTokenResponse } from '../interfaces/api-response';
@@ -26,7 +28,6 @@ import {
 } from '../interfaces/installation-entry';
 import { compareHeaders } from '../testing/compare-headers';
 import { getFakeAppConfig } from '../testing/get-fake-app';
-import '../testing/setup';
 import {
   INSTALLATIONS_API_URL,
   INTERNAL_AUTH_VERSION,

packages/installations/src/functions/delete-installation.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { FirebaseApp } from '@firebase/app-types';
 import { expect } from 'chai';
 import { SinonStub, stub } from 'sinon';
@@ -29,7 +31,6 @@ import {
   UnregisteredInstallationEntry
 } from '../interfaces/installation-entry';
 import { getFakeApp } from '../testing/get-fake-app';
-import '../testing/setup';
 import { ErrorCode } from '../util/errors';
 import { sleep } from '../util/sleep';
 import { deleteInstallation } from './delete-installation';

packages/installations/src/functions/get-id.test.ts

@@ -15,13 +15,14 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { SinonStub, stub } from 'sinon';
 import * as getInstallationEntryModule from '../helpers/get-installation-entry';
 import { AppConfig } from '../interfaces/app-config';
 import { RequestStatus } from '../interfaces/installation-entry';
 import { getFakeApp } from '../testing/get-fake-app';
-import '../testing/setup';
 import { getId } from './get-id';
 
 const FID = 'children-of-the-damned';

packages/installations/src/functions/get-token.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { FirebaseApp } from '@firebase/app-types';
 import { expect } from 'chai';
 import { SinonFakeTimers, SinonStub, stub, useFakeTimers } from 'sinon';
@@ -31,7 +33,6 @@ import {
   UnregisteredInstallationEntry
 } from '../interfaces/installation-entry';
 import { getFakeApp } from '../testing/get-fake-app';
-import '../testing/setup';
 import { TOKEN_EXPIRATION_BUFFER } from '../util/constants';
 import { ERROR_FACTORY, ErrorCode } from '../util/errors';
 import { sleep } from '../util/sleep';

packages/installations/src/helpers/buffer-to-base64-url-safe.test.ts

@@ -15,8 +15,9 @@
  * limitations under the License.
  */
 
-import { expect } from 'chai';
 import '../testing/setup';
+
+import { expect } from 'chai';
 import { bufferToBase64UrlSafe } from './buffer-to-base64-url-safe';
 
 const TYPED_ARRAY_REPRESENTATION = new TextEncoder().encode('hello world');

packages/installations/src/helpers/extract-app-config.test.ts

@@ -15,11 +15,12 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { FirebaseError } from '@firebase/util';
 import { expect } from 'chai';
 import { AppConfig } from '../interfaces/app-config';
 import { getFakeApp } from '../testing/get-fake-app';
-import '../testing/setup';
 import { extractAppConfig } from './extract-app-config';
 
 describe('extractAppConfig', () => {

packages/installations/src/helpers/generate-fid.test.ts

@@ -15,9 +15,10 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { stub } from 'sinon';
-import '../testing/setup';
 import { generateFid } from './generate-fid';
 
 /** A few random values to generate a FID from. */

packages/installations/src/helpers/get-installation-entry.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { AssertionError, expect } from 'chai';
 import { SinonFakeTimers, SinonStub, stub, useFakeTimers } from 'sinon';
 import * as createInstallationModule from '../api/create-installation';
@@ -27,7 +29,6 @@ import {
   UnregisteredInstallationEntry
 } from '../interfaces/installation-entry';
 import { getFakeAppConfig } from '../testing/get-fake-app';
-import '../testing/setup';
 import { ERROR_FACTORY, ErrorCode } from '../util/errors';
 import { sleep } from '../util/sleep';
 import * as fidGenerator from './generate-fid';

packages/installations/src/helpers/idb-manager.test.ts

@@ -15,10 +15,11 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { AppConfig } from '../interfaces/app-config';
 import { getFakeAppConfig } from '../testing/get-fake-app';
-import '../testing/setup';
 import { clear, get, remove, set, update } from './idb-manager';
 
 describe('idb manager', () => {

packages/installations/src/testing/compare-headers.test.ts

@@ -15,8 +15,9 @@
  * limitations under the License.
  */
 
-import { AssertionError, expect } from 'chai';
 import '../testing/setup';
+
+import { AssertionError, expect } from 'chai';
 import { compareHeaders } from './compare-headers';
 
 describe('compareHeaders', () => {

packages/installations/src/testing/setup.ts

@@ -15,12 +15,15 @@
  * limitations under the License.
  */
 
+import { root } from '@firebase/util';
 import { use } from 'chai';
 import * as chaiAsPromised from 'chai-as-promised';
 import { restore } from 'sinon';
 import * as sinonChai from 'sinon-chai';
 import { clear } from '../helpers/idb-manager';
 
+root.__VERSION__ = '__VERSION__';
+
 use(chaiAsPromised);
 use(sinonChai);
 

packages/installations/src/util/sleep.test.ts

@@ -15,9 +15,10 @@
  * limitations under the License.
  */
 
+import '../testing/setup';
+
 import { expect } from 'chai';
 import { SinonFakeTimers, useFakeTimers } from 'sinon';
-import '../testing/setup';
 import { sleep } from './sleep';
 
 describe('sleep', () => {

packages/performance/package.json

@@ -13,8 +13,7 @@
   "scripts": {
     "build": "rollup -c",
     "dev": "rollup -c -w",
-    "test": "run-p test:browser",
-    "test:browser": "karma start --single-run",
+    "test": "karma start --single-run",
     "test:debug": "karma start --browsers=Chrome --auto-watch",
     "prepare": "yarn build",
     "prettier": "prettier --write '{src,test}/**/*.{js,ts}'"

packages/performance/src/controllers/perf.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import { expect } from 'chai';
 import { PerformanceController } from '../controllers/perf';
 import { Trace } from '../resources/trace';

packages/performance/src/resources/network_request.test.ts

@@ -15,13 +15,14 @@
  * limitations under the License.
  */
 
-import { stub, restore } from 'sinon';
+import '../../test/setup';
+
+import { stub } from 'sinon';
 import { createNetworkRequestEntry } from '../../src/resources/network_request';
 import { expect } from 'chai';
 import { Api } from '../services/api_service';
 import * as perfLogger from '../services/perf_logger';
 import { setupApi } from '../services/api_service';
-import '../../test/setup';
 
 describe('Firebase Performance > network_request', () => {
   setupApi(window);
@@ -31,10 +32,6 @@ describe('Firebase Performance > network_request', () => {
     stub(perfLogger, 'logNetworkRequest');
   });
 
-  afterEach(() => {
-    restore();
-  });
-
   describe('#createNetworkRequestEntry', () => {
     it('logs network request when all required fields present', () => {
       const PERFORMANCE_ENTRY = ({

packages/performance/src/resources/trace.test.ts

@@ -15,13 +15,14 @@
  * limitations under the License.
  */
 
-import { spy, stub, restore } from 'sinon';
+import '../../test/setup';
+
+import { spy, stub } from 'sinon';
 import { Trace } from '../resources/trace';
 import { expect } from 'chai';
 import { Api } from '../services/api_service';
 import * as perfLogger from '../services/perf_logger';
 import { setupApi } from '../services/api_service';
-import '../../test/setup';
 
 describe('Firebase Performance > trace', () => {
   setupApi(window);
@@ -36,10 +37,6 @@ describe('Firebase Performance > trace', () => {
     trace = createTrace();
   });
 
-  afterEach(() => {
-    restore();
-  });
-
   describe('#start', () => {
     beforeEach(() => {
       trace.start();

packages/performance/src/services/api_service.test.ts

@@ -15,10 +15,11 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import { stub } from 'sinon';
 import { expect } from 'chai';
 import { Api, setupApi } from './api_service';
-import '../../test/setup';
 
 describe('Firebase Performance > api_service', () => {
   const PAGE_URL = 'http://www.test.com/abcd?a=2';

packages/performance/src/services/iid_service.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import { stub } from 'sinon';
 import { expect } from 'chai';
 import { SettingsService } from './settings_service';
@@ -25,7 +27,6 @@ import {
   getAuthTokenPromise
 } from './iid_service';
 import { FirebaseApp } from '@firebase/app-types';
-import '../../test/setup';
 
 describe('Firebase Perofmrance > iid_service', () => {
   const IID = 'fid';

packages/performance/src/services/initialization_service.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import { stub } from 'sinon';
 import { expect } from 'chai';
 import {
@@ -24,7 +26,6 @@ import {
 import { setupApi } from './api_service';
 import { SettingsService } from './settings_service';
 import { FirebaseApp } from '@firebase/app-types';
-import '../../test/setup';
 
 describe('Firebase Perofmrance > initialization_service', () => {
   const IID = 'fid';

packages/performance/src/services/oob_resources_service.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import {
   spy,
   stub,
@@ -29,7 +31,6 @@ import * as iidService from './iid_service';
 import { setupOobResources } from './oob_resources_service';
 import { createNetworkRequestEntry } from '../resources/network_request';
 import { Trace } from '../resources/trace';
-import '../../test/setup';
 
 describe('Firebase Performance > oob_resources_service', () => {
   const MOCK_ID = 'idasdfsffe';

packages/performance/src/services/perf_logger.test.ts

@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+import '../../test/setup';
+
 import { stub, SinonStub, useFakeTimers, SinonFakeTimers } from 'sinon';
 import { Trace } from '../resources/trace';
 import { LogHandler, Logger, LogLevel } from '@firebase/logger';
@@ -27,7 +29,6 @@ import { FirebaseApp } from '@firebase/app-types';
 import * as initializationService from './initialization_service';
 import * as attributeUtils from '../utils/attributes_utils';
 import { createNetworkRequestEntry } from '../resources/network_request';
-import '../../test/setup';
 
 describe('Performance Monitoring > perf_logger', () => {
   const IID = 'idasdfsffe';

packages/performance/src/services/remote_config_service.test.ts

@@ -14,6 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+import '../../test/setup';
+
 import { stub, SinonStub, useFakeTimers, SinonFakeTimers } from 'sinon';
 import { expect } from 'chai';
 import { SettingsService } from './settings_service';
@@ -22,7 +25,6 @@ import { setupApi } from './api_service';
 import * as iidService from './iid_service';
 import { getConfig } from './remote_config_service';
 import { FirebaseApp } from '@firebase/app-types';
-import '../../test/setup';
 
 describe('Performance Monitoring > remote_config_service', () => {
   const IID = 'asd123';