Few more comments to address

Author: hsubox76

packages/rxfire/database/utils.ts

@@ -23,7 +23,7 @@ import { ListenEvent } from './interfaces';
  * @param events
  */
 export function validateEventsArray(events?: ListenEvent[]): ListenEvent[] {
-  if (events == null || events!.length === 0) {
+  if (events == null || events.length === 0) {
     events = [
       ListenEvent.added,
       ListenEvent.removed,

packages/storage/test/blob.test.ts

@@ -78,9 +78,8 @@ describe('Firebase Storage > Blob', () => {
     const blob1 = new FbsBlob(arr1, true);
     const blob2 = new FbsBlob(arr2, true);
 
-    const concatenated = FbsBlob.getBlob(blob1, blob2);
+    const concatenated = FbsBlob.getBlob(blob1, blob2)!;
 
-    assert.isNotNull(concatenated);
     assert.equal(20, concatenated!.size());
   });
 });

packages/storage/test/testshared.ts

@@ -107,7 +107,9 @@ export function assertThrows(
     }
   }).to.throw();
   expect(captured).to.be.an.instanceof(FirebaseStorageError);
-  // @ts-ignore Compiler thinks catch block is unreachable.
+  // @ts-ignore Compiler does not know callback is invoked immediately and
+  // thinks catch block is unreachable. This is an open TS issue:
+  // https://github.com/microsoft/TypeScript/issues/11498
   expect(captured.code).to.equal(code);
   return captured as FirebaseStorageError | null;
 }

packages/util/src/sha1.ts

@@ -43,29 +43,25 @@ export class Sha1 {
   /**
    * Holds the previous values of accumulated variables a-e in the compress_
    * function.
-   * @type {!number[]}
    * @private
    */
   private chain_: number[] = [];
 
   /**
    * A buffer holding the partially computed hash result.
-   * @type {!number[]}
    * @private
    */
   private buf_: number[] = [];
 
   /**
    * An array of 80 bytes, each a part of the message to be hashed.  Referred to
    * as the message schedule in the docs.
-   * @type {!number[]}
    * @private
    */
   private W_: number[] = [];
 
   /**
    * Contains data needed to pad messages less than 64 bytes.
-   * @type {!number[]}
    * @private
    */
   private pad_: number[] = [];