Handle case where the server does not return an FID (#1936)

Author: mmermerkaya

packages/installations/src/api/create-installation.test.ts

@@ -105,6 +105,24 @@ describe('createInstallation', () => {
     });
   });
 
+  it('returns the FID from the request if the response does not contain one', async () => {
+    response = {
+      refreshToken: 'refreshToken',
+      authToken: {
+        token:
+          'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCeKKF2QT4fwpMeJf36POk6yJV_adQssw5c',
+        expiresIn: '604800s'
+      }
+    };
+    fetchSpy.resolves(new Response(JSON.stringify(response)));
+
+    const registeredInstallationEntry = await createInstallation(
+      appConfig,
+      inProgressInstallationEntry
+    );
+    expect(registeredInstallationEntry.fid).to.equal(FID);
+  });
+
   describe('failed request', () => {
     it('throws a FirebaseError with the error information from the server', async () => {
       const errorResponse: ErrorResponse = {

packages/installations/src/api/create-installation.ts

@@ -55,7 +55,7 @@ export async function createInstallation(
   if (response.ok) {
     const responseValue: CreateInstallationResponse = await response.json();
     const registeredInstallationEntry: RegisteredInstallationEntry = {
-      fid: responseValue.fid,
+      fid: responseValue.fid || fid,
       registrationStatus: RequestStatus.COMPLETED,
       refreshToken: responseValue.refreshToken,
       authToken: extractAuthTokenInfoFromResponse(responseValue.authToken)

packages/installations/src/interfaces/api-response.ts

@@ -18,7 +18,7 @@
 export interface CreateInstallationResponse {
   readonly refreshToken: string;
   readonly authToken: GenerateAuthTokenResponse;
-  readonly fid: string;
+  readonly fid?: string;
 }
 
 export interface GenerateAuthTokenResponse {