Skip to content

Commit e8bf439

Browse files
committed
fix typings
1 parent 2e0849a commit e8bf439

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages-exp/app-compat/src/firebaseNamespaceCore.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
} from './types';
2424
import * as modularAPIs from '@firebase/app-exp';
2525
import { _FirebaseAppInternal as _FirebaseAppExp } from '@firebase/app-exp';
26-
import { Component, ComponentType } from '@firebase/component';
26+
import { Component, ComponentType, Name } from '@firebase/component';
2727

2828
import { deepExtend, contains } from '@firebase/util';
2929
import { FirebaseAppImpl } from './firebaseApp';
@@ -131,8 +131,8 @@ export function createFirebaseNamespaceCore(
131131
return Object.keys(apps).map(name => apps[name]);
132132
}
133133

134-
function registerComponentCompat(
135-
component: Component
134+
function registerComponentCompat<T extends Name>(
135+
component: Component<T>
136136
): FirebaseServiceNamespace<_FirebaseService> | null {
137137
const componentName = component.name;
138138
const componentNameWithoutCompat = componentName.replace('-compat', '');

packages-exp/app-compat/src/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
import { FirebaseApp, FirebaseNamespace } from './public-types';
2424
import { Compat } from '@firebase/util';
25-
import { Component, ComponentContainer } from '@firebase/component';
25+
import { Component, ComponentContainer, Name } from '@firebase/component';
2626

2727
export interface FirebaseServiceInternals {
2828
/**
@@ -72,8 +72,8 @@ export interface _FirebaseNamespace extends FirebaseNamespace {
7272
* @param allowMultipleInstances Whether the registered service supports
7373
* multiple instances per app. If not specified, the default is false.
7474
*/
75-
registerComponent(
76-
component: Component
75+
registerComponent<T extends Name>(
76+
component: Component<T>
7777
): FirebaseServiceNamespace<_FirebaseService> | null;
7878

7979
/**

0 commit comments

Comments
 (0)