Skip to content

Commit f129975

Browse files
authored
remove side effect imports (#3534)
* remove side effect imports * registerFirestore before test
1 parent 41ed6f2 commit f129975

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

packages/firestore/exp/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515
* limitations under the License.
1616
*/
1717

18-
import './register';
18+
import { registerFirestore } from './register';
19+
20+
registerFirestore();
1921

2022
export { FieldPath, documentId } from '../lite/src/api/field_path';
2123

packages/firestore/exp/register.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,3 @@ export function registerFirestore(): void {
3737
);
3838
registerVersion('firestore-exp', version, 'node');
3939
}
40-
41-
registerFirestore();

packages/firestore/exp/test/bootstrap.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* limitations under the License.
1616
*/
1717

18-
import '../register';
19-
18+
import { registerFirestore } from '../register';
19+
registerFirestore();
2020
/**
2121
* This will include all of the test files and compile them as needed
2222
*

packages/firestore/lite/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515
* limitations under the License.
1616
*/
1717

18-
import './register';
18+
import { registerFirestore } from './register';
19+
20+
registerFirestore();
1921

2022
export {
2123
Firestore as FirebaseFirestore,

packages/firestore/lite/register.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,3 @@ export function registerFirestore(): void {
3737
);
3838
registerVersion('firestore-lite', version, 'node');
3939
}
40-
41-
registerFirestore();

packages/firestore/lite/test/bootstrap.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* limitations under the License.
1616
*/
1717

18-
import '../register';
19-
18+
import { registerFirestore } from '../register';
19+
registerFirestore();
2020
/**
2121
* This will include all of the test files and compile them as needed
2222
*

0 commit comments

Comments
 (0)