Skip to content

remove side effect imports #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2020
Merged

remove side effect imports #3534

merged 4 commits into from
Aug 7, 2020

Conversation

Feiyang1
Copy link
Member

Side effect imports cause some issue in the compilation since we use moduleSideEffects: false in the rollup config. The rollup flag won't be necessary once we get out of the exp phase, so we can change it back to the original way once that happens.

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2020

💥 No Changeset

Latest commit: 8f5496c

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore/exp

    Type Base (41ed6f2) Head (dfffb8b) Diff
    browser 188 kB 189 kB +271 B (+0.1%)
    main 467 kB 468 kB +473 B (+0.1%)
    module 188 kB 189 kB +271 B (+0.1%)
    react-native 188 kB 189 kB +272 B (+0.1%)
  • @firebase/firestore/lite

    Type Base (41ed6f2) Head (dfffb8b) Diff
    browser 64.3 kB 64.6 kB +276 B (+0.4%)
    main 142 kB 143 kB +463 B (+0.3%)
    module 64.3 kB 64.6 kB +276 B (+0.4%)
    react-native 64.4 kB 64.7 kB +280 B (+0.4%)

Test Logs

@Feiyang1 Feiyang1 merged commit f129975 into master Aug 7, 2020
@Feiyang1 Feiyang1 deleted the fei-firestore-no-sideeffect branch August 7, 2020 19:43
@firebase firebase locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants