Skip to content

remove side effect imports #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2020
Merged

remove side effect imports #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c5bec3
remove side effect imports
Feiyang1 Jul 31, 2020
370a082
Merge branch 'master' into fei-firestore-no-sideeffect
Feiyang1 Aug 6, 2020
39f2bdd
Merge branch 'master' into fei-firestore-no-sideeffect
Feiyang1 Aug 7, 2020
8f5496c
registerFirestore before test
Feiyang1 Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/firestore/exp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
* limitations under the License.
*/

import './register';
import { registerFirestore } from './register';

registerFirestore();

export { FieldPath, documentId } from '../lite/src/api/field_path';

Expand Down
2 changes: 0 additions & 2 deletions packages/firestore/exp/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,3 @@ export function registerFirestore(): void {
);
registerVersion('firestore-exp', version, 'node');
}

registerFirestore();
4 changes: 2 additions & 2 deletions packages/firestore/exp/test/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
* limitations under the License.
*/

import '../register';

import { registerFirestore } from '../register';
registerFirestore();
/**
* This will include all of the test files and compile them as needed
*
Expand Down
4 changes: 3 additions & 1 deletion packages/firestore/lite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
* limitations under the License.
*/

import './register';
import { registerFirestore } from './register';

registerFirestore();

export {
Firestore as FirebaseFirestore,
Expand Down
2 changes: 0 additions & 2 deletions packages/firestore/lite/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,3 @@ export function registerFirestore(): void {
);
registerVersion('firestore-lite', version, 'node');
}

registerFirestore();
4 changes: 2 additions & 2 deletions packages/firestore/lite/test/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
* limitations under the License.
*/

import '../register';

import { registerFirestore } from '../register';
registerFirestore();
/**
* This will include all of the test files and compile them as needed
*
Expand Down