Remove docKey

Author: schmidt-sebastian

packages/firestore/src/local/local_store_impl.ts

@@ -1035,7 +1035,7 @@ function applyWriteToRemoteDocuments(
           'ackVersions should contain every doc in the write.'
         );
         if (doc.version.compareTo(ackVersion!) < 0) {
-          batch.applyToRemoteDocument(docKey, doc, batchResult);
+          batch.applyToRemoteDocument(doc, batchResult);
           if (doc.isValidDocument()) {
             // We use the commitVersion as the readTime rather than the
             // document's updateTime since the updateTime is not advanced

packages/firestore/src/model/mutation.ts

@@ -246,9 +246,9 @@ export function applyMutationToRemoteDocument(
 }
 
 /**
- * Applies this mutation to the given document or null for the purposes of
- * computing the new local view of a document. If the input document doesn't
- * match the expected state, the document is not modified.
+ * Applies this mutation to the given document for the purposes of computing
+ * the new local view of a document. If the input document doesn't match the
+ * expected state, the document is not modified.
  *
  * @param mutation - The mutation to apply.
  * @param document - The document to mutate. The input document can be an

packages/firestore/src/model/mutation_batch.ts

@@ -64,15 +64,13 @@ export class MutationBatch {
 
   /**
    * Applies all the mutations in this MutationBatch to the specified document
-   * to create a new remote document
+   * to compute the state of the remote document
    *
-   * @param docKey - The key of the document to apply mutations to.
    * @param document - The document to apply mutations to.
    * @param batchResult - The result of applying the MutationBatch to the
    * backend.
    */
   applyToRemoteDocument(
-    docKey: DocumentKey,
     document: MutableDocument,
     batchResult: MutationBatchResult
   ): void {
@@ -86,7 +84,7 @@ export class MutationBatch {
 
     for (let i = 0; i < this.mutations.length; i++) {
       const mutation = this.mutations[i];
-      if (mutation.key.isEqual(docKey)) {
+      if (mutation.key.isEqual(document.key)) {
         const mutationResult = mutationResults[i];
         applyMutationToRemoteDocument(mutation, document, mutationResult);
       }