Skip to content

[Multi-Tab] Using WebStorage Mock with all IndexedDB tests #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2018
Merged

[Multi-Tab] Using WebStorage Mock with all IndexedDB tests #1034

merged 3 commits into from
Jul 20, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

For Mike.

This also makes it possible to run the WebStorageSharedClientTest in Node.

mikelehen
mikelehen approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schmidt-sebastian schmidt-sebastian merged commit 23adc0e into firestore-multi-tab Jul 20, 2018
@schmidt-sebastian schmidt-sebastian deleted the multitab-nomorewarnings branch August 3, 2018 17:15
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@wilhuff wilhuff Awaiting requested review from wilhuff

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @mikelehen @google-oss-bot