Comment out multi-tab flag #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
bojeil-google,
depoll,
hiranya911,
jshcrowthe,
mikelehen and
wilhuff
as code owners
schmidt-sebastian
removed request for
depoll,
hiranya911,
jshcrowthe,
wilhuff and
bojeil-google
mikelehen
approved these changes
Jul 25, 2018
| @@ -808,6 +829,29 @@ declare namespace firebase.firestore { | |||
| */ | |||
| enablePersistence(): Promise<void>; | |||
|
|
|||
| // TODO(multitab): Uncomment when multi-tab is released publicly. | |||
There was a problem hiding this comment.
I assume we'll do the right thing, but really this should be "Uncomment (and remove above version) when. .."
There was a problem hiding this comment.
I'll take care of that when the day comes :)
| // * There are several reasons why this can fail, which can be identified by | ||
| // * the `code` on the error. | ||
| // * | ||
| // * * failed-precondition: The app is already open in another browser tab. |
There was a problem hiding this comment.
Technically this should probably have some mention of experimentalTabSynchronization... but since it's experimental maybe we don't care to give it too much verbiage in this method description...
| @@ -202,6 +202,10 @@ class FirestoreConfig { | |||
| persistence: boolean; | |||
| } | |||
|
|
|||
| // TODO(multi-tab): Replace with Firestore.PersistenceSettings | |||
There was a problem hiding this comment.
multitab (or else pinky swear that you'll grep for "TODO(multi" before we declare multi-tab done).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comments out the multi-tab flag in one
.d.tsfile and adds it to another (where I missed adding it).