Skip to content

Upgrade GRPC to 1.13.1 #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Upgrade GRPC to 1.13.1 #1042

merged 2 commits into from
Jul 25, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 24, 2018

Addresses grpc/grpc-node#453 in Firestore.

Also fixes #1036

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 removed their assignment Jul 25, 2018
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit d61fbb2 into master Jul 25, 2018
@Nantris
Copy link

Nantris commented Jul 25, 2018

Is there an eta for a new release to npm?

@hiranya911
Copy link
Contributor

@slapbox Possibly later this week.

@Nantris
Copy link

Nantris commented Jul 25, 2018

Thanks very much for the update @hiranya911

@jajaperson
Copy link

It's been over a week since this was merged. Why hasn't it been released yet?

@schmidt-sebastian schmidt-sebastian deleted the grpcuprage branch August 3, 2018 17:15
@schmidt-sebastian
Copy link
Contributor Author

We are having some trouble with our release pipeline and are actively working on pushing the new release. Thanks for your patience.

@Nantris
Copy link

Nantris commented Aug 3, 2018

@schmidt-sebastian Thanks very much for the update. The community definitely appreciates it!

@k0d3d
Copy link

k0d3d commented May 2, 2019

using [email protected] also fixes it. I had to remove node_modules and edit package-lock.json before npm i [email protected] --force to make sure it worked

@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Firestore without abandoning this package? UNSAFE DEPENDENCY
7 participants