Firestore: in tests, silence the verbose warning about old timestamp behavior #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
commented
Jul 27, 2018
| @@ -46,15 +46,16 @@ export const FIRESTORE = new Firestore({ | |||
| }); | |||
|
|
|||
| export function firestore(): Firestore { | |||
| FIRESTORE.settings({timestampsInSnapshots: true}); | |||
There was a problem hiding this comment.
Not sure about this change. Can/should I modify FIRESTORE right after it is defined in the global scope?
There was a problem hiding this comment.
I think it would be fine to move this out of the firestore() function, if that's what you're asking. I don't have a strong preference.
There was a problem hiding this comment.
Ok, I guess I'll merge as is, then.
mikelehen
approved these changes
Jul 27, 2018
| @@ -46,15 +46,16 @@ export const FIRESTORE = new Firestore({ | |||
| }); | |||
|
|
|||
| export function firestore(): Firestore { | |||
| FIRESTORE.settings({timestampsInSnapshots: true}); | |||
There was a problem hiding this comment.
I think it would be fine to move this out of the firestore() function, if that's what you're asking. I don't have a strong preference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the few leftover places where the warning was still being outputted in tests. Running locally, I get a clean log.