Add Watch update perf test #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt-moreperftests
branch
from
2e90f88 to
d0b90ea
Compare
mikelehen
approved these changes
Jul 30, 2018
| let steps = spec().withGCEnabled(false); | ||
|
|
||
| for (let i = 1; i <= STEP_COUNT; ++i) { | ||
| const collPath = `collection/${i}/coll`; |
There was a problem hiding this comment.
Why do you use a different subcollection for each step_count ? Please comment.
There was a problem hiding this comment.
Added comment. I want the loop iterations to be distinct.
|
|
||
| for (let i = 1; i <= STEP_COUNT; ++i) { | ||
| const collPath = `collection/${i}/coll`; | ||
| const matchingDoc = doc(`${collPath}/${i}`, ++currentVersion, { |
There was a problem hiding this comment.
given you're already using a separate subcollection, does the doc name need to be unique too or could this just be ${collPath}/match or something ?
There was a problem hiding this comment.
Yes, that works. Done.
|
|
||
| const queries = []; | ||
|
|
||
| for (let j = 0; j < queriesPerStep; ++j) { |
There was a problem hiding this comment.
Comments explaining each section of the test would help me read it faster and be sure I was understanding the intention... E.g.
// Create queriesPerStep listens, each against collPath but with a unique query constraint.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have n-updates for n targets, we update the DbTargetGlobal store n times. In the multi-tab branch, this even adds n reads. This perf tests will be used in my follow-up PR that gets rid of these extra updates.
This test is so slow at 100 queries per round that I reduced it to 25.